<html><head><meta http-equiv="Content-Type" content="text/html charset=windows-1252"></head><body style="word-wrap: break-word; -webkit-nbsp-mode: space; -webkit-line-break: after-white-space; "><br><div><div>On Apr 30, 2012, at 7:02 PM, Chandler Carruth <<a href="mailto:chandlerc@google.com">chandlerc@google.com</a>> wrote:</div><br class="Apple-interchange-newline"><blockquote type="cite"><div class="gmail_quote">On Mon, Apr 30, 2012 at 6:43 PM, Douglas Gregor <span dir="ltr"><<a href="mailto:dgregor@apple.com" target="_blank">dgregor@apple.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin: 0px 0px 0px 0.8ex; border-left-width: 1px; border-left-color: rgb(204, 204, 204); border-left-style: solid; padding-left: 1ex; position: static; z-index: auto; ">
<div class="HOEnZb"><div class="h5"><br>
On Mar 21, 2012, at 3:07 AM, Jonathan Gray <<a href="mailto:jsg@jsg.id.au">jsg@jsg.id.au</a>> wrote:<br>
<br>
> In test/Driver/clang-g-opts.c with tests of the form<br>
><br>
> // RUN: %clang -S -v -o %t %s 2>&1 | not grep -w -- -g<br>
><br>
> using 'not' here isn't portable and doesn't work on at least<br>
> OpenBSD and likely other systems (bash builtin?).<br>
><br>
> patch to move this to FileCheck attached<br>
<br>
</div></div>Committed as r155874, thanks!<br></blockquote><div><br></div><div>See my comments on the commit, I don't think this is a correct patch.</div><div><br></div><div>Move-over, 'not' *is* portable, as we build the 'not' command out of the LLVM tree?</div>
<div><br></div><div>I fully support moving it to filecheck, but the reason as stated doesn't comute for me. </div></div></blockquote><br></div><div>And… I completely misread the patch. Reverted in r155878.</div><div><br></div><div><span class="Apple-tab-span" style="white-space:pre"> </span>- Doug</div></body></html>