<br><br><div class="gmail_quote">Le 14 avril 2012 15:21, Benjamin Kramer <span dir="ltr"><<a href="mailto:benny.kra@googlemail.com">benny.kra@googlemail.com</a>></span> a écrit :<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
Author: d0k<br>
Date: Sat Apr 14 08:21:23 2012<br>
New Revision: 154747<br>
<br>
URL: <a href="http://llvm.org/viewvc/llvm-project?rev=154747&view=rev" target="_blank">http://llvm.org/viewvc/llvm-project?rev=154747&view=rev</a><br>
Log:<br>
Don't leak vtable thunks.<br>
<br>
Modified:<br>
    cfe/trunk/lib/AST/VTableBuilder.cpp<br>
<br>
Modified: cfe/trunk/lib/AST/VTableBuilder.cpp<br>
URL: <a href="http://llvm.org/viewvc/llvm-project/cfe/trunk/lib/AST/VTableBuilder.cpp?rev=154747&r1=154746&r2=154747&view=diff" target="_blank">http://llvm.org/viewvc/llvm-project/cfe/trunk/lib/AST/VTableBuilder.cpp?rev=154747&r1=154746&r2=154747&view=diff</a><br>

==============================================================================<br>
--- cfe/trunk/lib/AST/VTableBuilder.cpp (original)<br>
+++ cfe/trunk/lib/AST/VTableBuilder.cpp Sat Apr 14 08:21:23 2012<br>
@@ -2163,6 +2163,7 @@<br>
<br>
 VTableLayout::~VTableLayout() {<br>
   delete[] VTableComponents;<br>
+  delete[] VTableThunks;<br>
 }<br>
<br>
 VTableContext::~VTableContext() {<br>
<br>
<br>
_______________________________________________<br>
cfe-commits mailing list<br>
<a href="mailto:cfe-commits@cs.uiuc.edu">cfe-commits@cs.uiuc.edu</a><br>
<a href="http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits" target="_blank">http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits</a><br>
</blockquote></div><br>Hello,<br><br>I understand that sometimes memory management is not easy (while making use of other containers for example), however this seems a prime example for using OwningArrayPtr [1].<br><br>Is there a specific reason it cannot be done ? It seems less error prone to me that manually deleting the memory, as your commit proves.<br>
<br>[1]: <a href="http://llvm.org/docs/doxygen/html/classllvm_1_1OwningArrayPtr.html">http://llvm.org/docs/doxygen/html/classllvm_1_1OwningArrayPtr.html</a><br>
<br>
-- Matthieu