Removed all standalone whitespace-only changes.<br><br><div class="gmail_quote">On Thu, Apr 5, 2012 at 1:32 AM, Chandler Carruth <span dir="ltr"><<a href="mailto:chandlerc@google.com">chandlerc@google.com</a>></span> wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div class="gmail_quote"><div class="im">On Thu, Apr 5, 2012 at 2:02 AM, Alexander Kornienko <span dir="ltr"><<a href="mailto:alexfh@google.com" target="_blank">alexfh@google.com</a>></span> wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
Ok, I'm not very good at editing diff files, but hope, that this should be a valid patch. BTW, svn diff -x --ignore-eol-style doesn't seem to help</blockquote><div><br></div></div><div>In general, you will need to reconfigure your editor to not modify whitespace outside of the code you are actually touching. It's disruptive to both code review, and to the revision history of those lines of code. You should only be touching whitespace when you're already going to touch adjacent lines of code.</div>
<div><div class="h5">
<div> </div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div><div><br><br><div class="gmail_quote">On Wed, Apr 4, 2012 at 4:36 PM, Jordan Rose <span dir="ltr"><<a href="mailto:jediknil@belkadan.com" target="_blank">jediknil@belkadan.com</a>></span> wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">Sorry, but similarly, can you filter out the whitespace-only changes? They're all good, I presume, but they might as well be in a separate patch.<br>
<br>
svn diff -x --ignore-eol-style<br>
git diff --ignore-space-at-eol<br>
<br>
Jordy<br>
<div><div><br>
<br>
<br>
On Apr 4, 2012, at 19:18, Alexander Kornienko wrote:<br>
<br>
> Hi Chandler,<br>
><br>
> You are right, it's better to separate apples from oranges. Here's a patch for statement attributes implementation. I'll post the rest after dealing with this one.<br>
><br>
> On Wed, Apr 4, 2012 at 3:46 PM, Chandler Carruth <<a href="mailto:chandlerc@google.com" target="_blank">chandlerc@google.com</a>> wrote:<br>
> I've not looked at the patch yet, but to make reviewing easier:<br>
><br>
><br>
> On Wed, Apr 4, 2012 at 11:01 PM, Alexander Kornienko <<a href="mailto:alexfh@google.com" target="_blank">alexfh@google.com</a>> wrote:<br>
> I've also implemented one specific statement attribute as an example<br>
><br>
> Can you please split the generic statement attribute work and the new attribute into two patches? These should be reviewed independently. One is a step toward support of a standard feature, the other is a brand new language extension. These have very different code review paths.<br>
><br>
><br>
><br>
> --<br>
> Alexander Kornienko | Software Engineer | <a href="mailto:alexfh@google.com" target="_blank">alexfh@google.com</a> | <a href="tel:%2B49%20151%20221%2077%20957" value="+4915122177957" target="_blank">+49 151 221 77 957</a><br>
> Google Germany GmbH | Dienerstr. 12 | 80331 München<br>
><br>
> AG Hamburg, HRB 86891 | Sitz der Gesellschaft: Hamburg<br>
> Geschäftsführer: Graham Law, Katherine Stephens<br>
><br>
> Tax ID:- 48/725/00206<br>
> VAT ID:- DE813741370<br>
><br>
</div></div>> <stmt-attributes3.diff>_______________________________________________<br>
> cfe-commits mailing list<br>
> <a href="mailto:cfe-commits@cs.uiuc.edu" target="_blank">cfe-commits@cs.uiuc.edu</a><br>
> <a href="http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits" target="_blank">http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits</a><br>
<br>
</blockquote></div><br><br clear="all"><div><br></div>-- <br><div><div><font color="#666666"><span style="border-top-width:2px;border-right-width:0px;border-bottom-width:0px;border-left-width:0px;border-top-style:solid;border-right-style:solid;border-bottom-style:solid;border-left-style:solid;border-top-color:rgb(213,15,37);border-right-color:rgb(213,15,37);border-bottom-color:rgb(213,15,37);border-left-color:rgb(213,15,37);padding-top:2px;margin-top:2px">Alexander Kornienko |</span><span style="border-top-width:2px;border-right-width:0px;border-bottom-width:0px;border-left-width:0px;border-top-style:solid;border-right-style:solid;border-bottom-style:solid;border-left-style:solid;border-top-color:rgb(51,105,232);border-right-color:rgb(51,105,232);border-bottom-color:rgb(51,105,232);border-left-color:rgb(51,105,232);padding-top:2px;margin-top:2px"> Software Engineer |</span></font><span style="border-top-width:2px;border-right-width:0px;border-bottom-width:0px;border-left-width:0px;border-top-style:solid;border-right-style:solid;border-bottom-style:solid;border-left-style:solid;border-top-color:rgb(0,153,57);border-right-color:rgb(0,153,57);border-bottom-color:rgb(0,153,57);border-left-color:rgb(0,153,57);padding-top:2px;margin-top:2px"><font color="#666666"> </font><a href="mailto:alexfh@google.com" style="color:rgb(17,85,204)" target="_blank">alexfh@google.com</a> |</span><span style="border-top-width:2px;border-right-width:0px;border-bottom-width:0px;border-left-width:0px;border-top-style:solid;border-right-style:solid;border-bottom-style:solid;border-left-style:solid;border-top-color:rgb(238,178,17);border-right-color:rgb(238,178,17);border-bottom-color:rgb(238,178,17);border-left-color:rgb(238,178,17);padding-top:2px;margin-top:2px"> <a value="+35315435283" style="color:rgb(17,85,204)">+49 151 221 77 957</a></span></div>
</div><div><font color="#666666"><span style="font-family:Arial,Verdana,sans-serif">Google Germany GmbH | </span><span style="font-family:Arial,Verdana,sans-serif">Dienerstr. 12 | </span><span style="font-family:Arial,Verdana,sans-serif">80331 München</span></font></div>
<div><div style="font-size:13px;font-family:Arial,Verdana,sans-serif"><font color="#666666"><font><br>AG Hamburg, HRB 86891 | Sitz der Gesellschaft: </font><font face="arial, sans-serif">Hamburg</font><font><br>
Geschäftsführer: Graham Law, Katherine Stephens<span style="border-collapse:separate"><span style="font-family:inherit"><br></span></span></font></font></div><div style="font-size:13px;font-family:Arial,Verdana,sans-serif">
<font color="#666666"><br></font></div><div style="font-size:13px;font-family:Arial,Verdana,sans-serif"><font><span style="border-collapse:collapse"><font face="arial, sans-serif" color="#666666">Tax ID:- 48/725/00206 </font></span></font></div>
<div style="font-size:13px;font-family:Arial,Verdana,sans-serif"><font><span style="border-collapse:collapse"><font face="arial, sans-serif" color="#666666">VAT ID:- DE813741370</font></span></font></div>
</div><br>
</div></div><br>_______________________________________________<br>
cfe-commits mailing list<br>
<a href="mailto:cfe-commits@cs.uiuc.edu" target="_blank">cfe-commits@cs.uiuc.edu</a><br>
<a href="http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits" target="_blank">http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits</a><br>
<br></blockquote></div></div></div><br>
</blockquote></div><br><br clear="all"><div><br></div>-- <br><div><div><font color="#666666"><span style="border-top-width:2px;border-right-width:0px;border-bottom-width:0px;border-left-width:0px;border-top-style:solid;border-right-style:solid;border-bottom-style:solid;border-left-style:solid;border-top-color:rgb(213,15,37);border-right-color:rgb(213,15,37);border-bottom-color:rgb(213,15,37);border-left-color:rgb(213,15,37);padding-top:2px;margin-top:2px">Alexander Kornienko |</span><span style="border-top-width:2px;border-right-width:0px;border-bottom-width:0px;border-left-width:0px;border-top-style:solid;border-right-style:solid;border-bottom-style:solid;border-left-style:solid;border-top-color:rgb(51,105,232);border-right-color:rgb(51,105,232);border-bottom-color:rgb(51,105,232);border-left-color:rgb(51,105,232);padding-top:2px;margin-top:2px"> Software Engineer |</span></font><span style="border-top-width:2px;border-right-width:0px;border-bottom-width:0px;border-left-width:0px;border-top-style:solid;border-right-style:solid;border-bottom-style:solid;border-left-style:solid;border-top-color:rgb(0,153,57);border-right-color:rgb(0,153,57);border-bottom-color:rgb(0,153,57);border-left-color:rgb(0,153,57);padding-top:2px;margin-top:2px"><font color="#666666"> </font><a href="mailto:alexfh@google.com" style="color:rgb(17,85,204)" target="_blank">alexfh@google.com</a> |</span><span style="border-top-width:2px;border-right-width:0px;border-bottom-width:0px;border-left-width:0px;border-top-style:solid;border-right-style:solid;border-bottom-style:solid;border-left-style:solid;border-top-color:rgb(238,178,17);border-right-color:rgb(238,178,17);border-bottom-color:rgb(238,178,17);border-left-color:rgb(238,178,17);padding-top:2px;margin-top:2px"> <a value="+35315435283" style="color:rgb(17,85,204)">+49 151 221 77 957</a></span></div>
</div><div><font color="#666666"><span style="background-color:rgb(255,255,255);font-family:Arial,Verdana,sans-serif">Google Germany GmbH | </span><span style="background-color:rgb(255,255,255);font-family:Arial,Verdana,sans-serif">Dienerstr. 12 | </span><span style="background-color:rgb(255,255,255);font-family:Arial,Verdana,sans-serif">80331 München</span></font></div>
<div><div style="font-family:Arial,Verdana,sans-serif;font-size:13px;background-color:rgb(255,255,255)"><font color="#666666"><font><br>AG Hamburg, HRB 86891 | Sitz der Gesellschaft: </font><font face="arial, sans-serif">Hamburg</font><font><br>
Geschäftsführer: Graham Law, Katherine Stephens<span style="border-collapse:separate"><span style="font-family:inherit"><br></span></span></font></font></div><div style="font-family:Arial,Verdana,sans-serif;font-size:13px;background-color:rgb(255,255,255)">
<font color="#666666"><br></font></div><div style="font-family:Arial,Verdana,sans-serif;font-size:13px;background-color:rgb(255,255,255)"><font><span style="border-collapse:collapse"><font face="arial, sans-serif" color="#666666">Tax ID:- 48/725/00206 </font></span></font></div>
<div style="font-family:Arial,Verdana,sans-serif;font-size:13px;background-color:rgb(255,255,255)"><font><span style="border-collapse:collapse"><font face="arial, sans-serif" color="#666666">VAT ID:- DE813741370</font></span></font></div>
</div><br>