<html><head></head><body style="word-wrap: break-word; -webkit-nbsp-mode: space; -webkit-line-break: after-white-space; "><div><div>On Mar 22, 2012, at 6:40 PM, Chandler Carruth wrote:</div><blockquote type="cite"><div class="gmail_quote">On Thu, Mar 22, 2012 at 5:49 PM, Kostya Serebryany <span dir="ltr"><<a href="mailto:kcc@google.com">kcc@google.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
Hello, <div><br></div><div>Please review the following patch which adds tbaa metadata nodes to vtable pointer loads/stores. </div><div>These metadata nodes will be immediately useful for ThreadSanitizer instrumentation (it needs to treat vtable updates in a special way). </div>
<div>They may also help various optimization phases that use the tbaa information. </div><div><a href="http://codereview.appspot.com/5881053" target="_blank">http://codereview.appspot.com/5881053</a></div></blockquote><div>
<br></div><div>The patch looks great to me, but you should wait for one of the Clang IRGen folks to look at it before submitting.</div></div></blockquote><br></div><div>It looks fine to me.</div><div><br></div><div>John.</div><div><br></div><br></body></html>