<div class="gmail_quote">Yea, it's failing for us too...</div><div class="gmail_quote"><br></div><div class="gmail_quote">On Mon, Mar 26, 2012 at 1:16 PM, Bill Wendling <span dir="ltr"><<a href="mailto:wendling@apple.com">wendling@apple.com</a>></span> wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">Hi Kostya,<br>
<br>
This is failing on our buildbots. Could you investigate, please?<br>
<br>
(view as text)<br>
******************** TEST 'Clang :: CodeGen/tbaa-for-vptr.cpp' FAILED ********************Script:<br>
--<br>
/Users/buildslave/zorg/buildbot/smooshlab/slave-0.8/build.clang-x86_64-darwin10-R/clang-build/Release/bin/clang -cc1 -internal-isystem /Users/buildslave/zorg/buildbot/smooshlab/slave-0.8/build.clang-x86_64-darwin10-R/clang-build/Release/bin/../lib/clang/3.1/include -emit-llvm -o - -O1 /Users/buildslave/zorg/buildbot/smooshlab/slave-0.8/build.clang-x86_64-darwin10-R/clang.src/test/CodeGen/tbaa-for-vptr.cpp | FileCheck /Users/buildslave/zorg/buildbot/smooshlab/slave-0.8/build.clang-x86_64-darwin10-R/clang.src/test/CodeGen/tbaa-for-vptr.cpp<br>

--<br>
Exit Code: 1<br>
Command Output (stderr):<br>
--<br>
/Users/buildslave/zorg/buildbot/smooshlab/slave-0.8/build.clang-x86_64-darwin10-R/clang.src/test/CodeGen/tbaa-for-vptr.cpp:16:11: error: expected string not found in input<br>
<div class="im">// CHECK: %vtable = load {{.*}} !tbaa !0<br>
</div>          ^<br>
<stdin>:1:1: note: scanning from here<br>
; ModuleID = '/Users/buildslave/zorg/buildbot/smooshlab/slave-0.8/build.clang-x86_64-darwin10-R/clang.src/test/CodeGen/tbaa-for-vptr.cpp'<br>
^<br>
<stdin>:28:32: note: possible intended match here<br>
 %2 = load i32 (%struct.A*)*** %1, align 8, !tbaa !0<br>
                               ^<br>
--<br>
<br>
********************<br>
<span class="HOEnZb"><font color="#888888"><br>
<br>
-bw<br>
</font></span><div class="HOEnZb"><div class="h5"><br>
On Mar 26, 2012, at 10:03 AM, Kostya Serebryany <<a href="mailto:kcc@google.com">kcc@google.com</a>> wrote:<br>
<br>
> Author: kcc<br>
> Date: Mon Mar 26 12:03:51 2012<br>
> New Revision: 153447<br>
><br>
> URL: <a href="http://llvm.org/viewvc/llvm-project?rev=153447&view=rev" target="_blank">http://llvm.org/viewvc/llvm-project?rev=153447&view=rev</a><br>
> Log:<br>
> add tbaa metadata to vtable pointer loads/stores<br>
><br>
> Added:<br>
>    cfe/trunk/test/CodeGen/tbaa-for-vptr.cpp<br>
> Modified:<br>
>    cfe/trunk/lib/CodeGen/CGClass.cpp<br>
>    cfe/trunk/lib/CodeGen/CodeGenModule.cpp<br>
>    cfe/trunk/lib/CodeGen/CodeGenModule.h<br>
>    cfe/trunk/lib/CodeGen/CodeGenTBAA.cpp<br>
>    cfe/trunk/lib/CodeGen/CodeGenTBAA.h<br>
><br>
> Modified: cfe/trunk/lib/CodeGen/CGClass.cpp<br>
> URL: <a href="http://llvm.org/viewvc/llvm-project/cfe/trunk/lib/CodeGen/CGClass.cpp?rev=153447&r1=153446&r2=153447&view=diff" target="_blank">http://llvm.org/viewvc/llvm-project/cfe/trunk/lib/CodeGen/CGClass.cpp?rev=153447&r1=153446&r2=153447&view=diff</a><br>

> ==============================================================================<br>
> --- cfe/trunk/lib/CodeGen/CGClass.cpp (original)<br>
> +++ cfe/trunk/lib/CodeGen/CGClass.cpp Mon Mar 26 12:03:51 2012<br>
> @@ -1514,7 +1514,8 @@<br>
>   llvm::Type *AddressPointPtrTy =<br>
>     VTableAddressPoint->getType()->getPointerTo();<br>
>   VTableField = Builder.CreateBitCast(VTableField, AddressPointPtrTy);<br>
> -  Builder.CreateStore(VTableAddressPoint, VTableField);<br>
> +  llvm::StoreInst *Store = Builder.CreateStore(VTableAddressPoint, VTableField);<br>
> +  CGM.DecorateInstruction(Store, CGM.getTBAAInfoForVTablePtr());<br>
> }<br>
><br>
> void<br>
> @@ -1597,7 +1598,9 @@<br>
> llvm::Value *CodeGenFunction::GetVTablePtr(llvm::Value *This,<br>
>                                            llvm::Type *Ty) {<br>
>   llvm::Value *VTablePtrSrc = Builder.CreateBitCast(This, Ty->getPointerTo());<br>
> -  return Builder.CreateLoad(VTablePtrSrc, "vtable");<br>
> +  llvm::Instruction *VTable = Builder.CreateLoad(VTablePtrSrc, "vtable");<br>
> +  CGM.DecorateInstruction(VTable, CGM.getTBAAInfoForVTablePtr());<br>
> +  return VTable;<br>
> }<br>
><br>
> static const CXXRecordDecl *getMostDerivedClassDecl(const Expr *Base) {<br>
><br>
> Modified: cfe/trunk/lib/CodeGen/CodeGenModule.cpp<br>
> URL: <a href="http://llvm.org/viewvc/llvm-project/cfe/trunk/lib/CodeGen/CodeGenModule.cpp?rev=153447&r1=153446&r2=153447&view=diff" target="_blank">http://llvm.org/viewvc/llvm-project/cfe/trunk/lib/CodeGen/CodeGenModule.cpp?rev=153447&r1=153446&r2=153447&view=diff</a><br>

> ==============================================================================<br>
> --- cfe/trunk/lib/CodeGen/CodeGenModule.cpp (original)<br>
> +++ cfe/trunk/lib/CodeGen/CodeGenModule.cpp Mon Mar 26 12:03:51 2012<br>
> @@ -182,6 +182,12 @@<br>
>   return TBAA->getTBAAInfo(QTy);<br>
> }<br>
><br>
> +llvm::MDNode *CodeGenModule::getTBAAInfoForVTablePtr() {<br>
> +  if (!TBAA)<br>
> +    return 0;<br>
> +  return TBAA->getTBAAInfoForVTablePtr();<br>
> +}<br>
> +<br>
> void CodeGenModule::DecorateInstruction(llvm::Instruction *Inst,<br>
>                                         llvm::MDNode *TBAAInfo) {<br>
>   Inst->setMetadata(llvm::LLVMContext::MD_tbaa, TBAAInfo);<br>
><br>
> Modified: cfe/trunk/lib/CodeGen/CodeGenModule.h<br>
> URL: <a href="http://llvm.org/viewvc/llvm-project/cfe/trunk/lib/CodeGen/CodeGenModule.h?rev=153447&r1=153446&r2=153447&view=diff" target="_blank">http://llvm.org/viewvc/llvm-project/cfe/trunk/lib/CodeGen/CodeGenModule.h?rev=153447&r1=153446&r2=153447&view=diff</a><br>

> ==============================================================================<br>
> --- cfe/trunk/lib/CodeGen/CodeGenModule.h (original)<br>
> +++ cfe/trunk/lib/CodeGen/CodeGenModule.h Mon Mar 26 12:03:51 2012<br>
> @@ -448,6 +448,7 @@<br>
>   bool shouldUseTBAA() const { return TBAA != 0; }<br>
><br>
>   llvm::MDNode *getTBAAInfo(QualType QTy);<br>
> +  llvm::MDNode *getTBAAInfoForVTablePtr();<br>
><br>
>   bool isTypeConstant(QualType QTy, bool ExcludeCtorDtor);<br>
><br>
><br>
> Modified: cfe/trunk/lib/CodeGen/CodeGenTBAA.cpp<br>
> URL: <a href="http://llvm.org/viewvc/llvm-project/cfe/trunk/lib/CodeGen/CodeGenTBAA.cpp?rev=153447&r1=153446&r2=153447&view=diff" target="_blank">http://llvm.org/viewvc/llvm-project/cfe/trunk/lib/CodeGen/CodeGenTBAA.cpp?rev=153447&r1=153446&r2=153447&view=diff</a><br>

> ==============================================================================<br>
> --- cfe/trunk/lib/CodeGen/CodeGenTBAA.cpp (original)<br>
> +++ cfe/trunk/lib/CodeGen/CodeGenTBAA.cpp Mon Mar 26 12:03:51 2012<br>
> @@ -179,3 +179,7 @@<br>
>   // For now, handle any other kind of type conservatively.<br>
>   return MetadataCache[Ty] = getChar();<br>
> }<br>
> +<br>
> +llvm::MDNode *CodeGenTBAA::getTBAAInfoForVTablePtr() {<br>
> +  return getTBAAInfoForNamedType("vtable pointer", getRoot());<br>
> +}<br>
><br>
> Modified: cfe/trunk/lib/CodeGen/CodeGenTBAA.h<br>
> URL: <a href="http://llvm.org/viewvc/llvm-project/cfe/trunk/lib/CodeGen/CodeGenTBAA.h?rev=153447&r1=153446&r2=153447&view=diff" target="_blank">http://llvm.org/viewvc/llvm-project/cfe/trunk/lib/CodeGen/CodeGenTBAA.h?rev=153447&r1=153446&r2=153447&view=diff</a><br>

> ==============================================================================<br>
> --- cfe/trunk/lib/CodeGen/CodeGenTBAA.h (original)<br>
> +++ cfe/trunk/lib/CodeGen/CodeGenTBAA.h Mon Mar 26 12:03:51 2012<br>
> @@ -68,6 +68,10 @@<br>
>   /// getTBAAInfo - Get the TBAA MDNode to be used for a dereference<br>
>   /// of the given type.<br>
>   llvm::MDNode *getTBAAInfo(QualType QTy);<br>
> +<br>
> +  /// getTBAAInfoForVTablePtr - Get the TBAA MDNode to be used for a<br>
> +  /// dereference of a vtable pointer.<br>
> +  llvm::MDNode *getTBAAInfoForVTablePtr();<br>
> };<br>
><br>
> }  // end namespace CodeGen<br>
><br>
> Added: cfe/trunk/test/CodeGen/tbaa-for-vptr.cpp<br>
> URL: <a href="http://llvm.org/viewvc/llvm-project/cfe/trunk/test/CodeGen/tbaa-for-vptr.cpp?rev=153447&view=auto" target="_blank">http://llvm.org/viewvc/llvm-project/cfe/trunk/test/CodeGen/tbaa-for-vptr.cpp?rev=153447&view=auto</a><br>

> ==============================================================================<br>
> --- cfe/trunk/test/CodeGen/tbaa-for-vptr.cpp (added)<br>
> +++ cfe/trunk/test/CodeGen/tbaa-for-vptr.cpp Mon Mar 26 12:03:51 2012<br>
> @@ -0,0 +1,19 @@<br>
> +// RUN: %clang_cc1 -emit-llvm -o - -O1 %s | FileCheck %s<br>
> +// Check that we generate TBAA for vtable pointer loads and stores.<br>
> +struct A {<br>
> +  virtual int foo() const ;<br>
> +  virtual ~A();<br>
> +};<br>
> +<br>
> +void CreateA() {<br>
> +  new A;<br>
> +}<br>
> +<br>
> +void CallFoo(A *a) {<br>
> +  a->foo();<br>
> +}<br>
> +<br>
> +// CHECK: %vtable = load {{.*}} !tbaa !0<br>
> +// CHECK: store {{.*}} !tbaa !0<br>
> +// CHECK: !0 = metadata !{metadata !"vtable pointer", metadata !1}<br>
> +// CHECK: !1 = metadata !{metadata !"Simple C/C++ TBAA", null}<br>
><br>
><br>
> _______________________________________________<br>
> cfe-commits mailing list<br>
> <a href="mailto:cfe-commits@cs.uiuc.edu">cfe-commits@cs.uiuc.edu</a><br>
> <a href="http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits" target="_blank">http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits</a><br>
<br>
_______________________________________________<br>
cfe-commits mailing list<br>
<a href="mailto:cfe-commits@cs.uiuc.edu">cfe-commits@cs.uiuc.edu</a><br>
<a href="http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits" target="_blank">http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits</a><br>
</div></div></blockquote></div><br>