<html><head></head><body style="word-wrap: break-word; -webkit-nbsp-mode: space; -webkit-line-break: after-white-space; "><br><div><div>On 23.03.2012, at 19:19, Richard Trieu wrote:</div><br class="Apple-interchange-newline"><blockquote type="cite"><div class="gmail_quote">On Fri, Mar 23, 2012 at 8:04 AM, Sebastian Redl <span dir="ltr"><<a href="mailto:sebastian.redl@getdesigned.at">sebastian.redl@getdesigned.at</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin-top: 0px; margin-right: 0px; margin-bottom: 0px; margin-left: 0.8ex; border-left-width: 1px; border-left-color: rgb(204, 204, 204); border-left-style: solid; padding-left: 1ex; position: static; z-index: auto; ">
<div class="im">On 22.03.2012 00:30, Richard Trieu wrote:<br>
> Author: rtrieu<br>
> Date: Wed Mar 21 18:30:30 2012<br>
> New Revision: 153226<br>
><br>
> URL: <a href="http://llvm.org/viewvc/llvm-project?rev=153226&view=rev" target="_blank">http://llvm.org/viewvc/llvm-project?rev=153226&view=rev</a><br>
> Log:<br>
> Change the binary operator data recursive evaluator to not stop at the first<br>
> non-constant value encountered. This allows the evaluator to deduce that<br>
> expressions like (x< 5 || true) is equal to true. Previously, it would visit<br>
> x and determined that the entire expression is could not evaluated to a<br>
> constant.<br>
><br>
</div>It should still stop evaluating if the LHS has side effects. Does that<br>
work correctly?<br>
<span class="HOEnZb"><font color="#888888"><br>
Sebastian<br>
</font></span><div class="HOEnZb"><div class="h5"><br></div></div></blockquote><div>Is it the expected behavior to stop when side effects are found? I stripped out the early exit so the evaluator will fully process every entry. The regression I fixed only requires the resulting value of the binary operator and didn't care about side-effects, so an early exit would likely show the problem again.</div>
</div>
</blockquote></div><br><div>Sorry, I was thinking about something else.</div><div><br></div><div>Sebastian</div></body></html>