<div class="gmail_quote">On Thu, Mar 15, 2012 at 6:04 PM, Eli Friedman <span dir="ltr"><<a href="mailto:eli.friedman@gmail.com">eli.friedman@gmail.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
<div class="HOEnZb"><div class="h5">On Wed, Mar 14, 2012 at 8:54 AM, Sebastian Redl<br>
<<a href="mailto:sebastian.redl@getdesigned.at">sebastian.redl@getdesigned.at</a>> wrote:<br>
> Author: cornedbee<br>
> Date: Wed Mar 14 10:54:00 2012<br>
> New Revision: 152721<br>
><br>
> URL: <a href="http://llvm.org/viewvc/llvm-project?rev=152721&view=rev" target="_blank">http://llvm.org/viewvc/llvm-project?rev=152721&view=rev</a><br>
> Log:<br>
> Parse brace initializers as default arguments. PR12236.<br>
><br>
> Modified:<br>
>    cfe/trunk/lib/Parse/ParseCXXInlineMethods.cpp<br>
>    cfe/trunk/lib/Parse/ParseDecl.cpp<br>
>    cfe/trunk/test/SemaCXX/cxx0x-initializer-scalars.cpp<br>
><br>
> Modified: cfe/trunk/lib/Parse/ParseCXXInlineMethods.cpp<br>
> URL: <a href="http://llvm.org/viewvc/llvm-project/cfe/trunk/lib/Parse/ParseCXXInlineMethods.cpp?rev=152721&r1=152720&r2=152721&view=diff" target="_blank">http://llvm.org/viewvc/llvm-project/cfe/trunk/lib/Parse/ParseCXXInlineMethods.cpp?rev=152721&r1=152720&r2=152721&view=diff</a><br>

> ==============================================================================<br>
> --- cfe/trunk/lib/Parse/ParseCXXInlineMethods.cpp (original)<br>
> +++ cfe/trunk/lib/Parse/ParseCXXInlineMethods.cpp Wed Mar 14 10:54:00 2012<br>
> @@ -319,7 +319,11 @@<br>
>                                             Sema::PotentiallyEvaluatedIfUsed,<br>
>                                             LM.DefaultArgs[I].Param);<br>
><br>
> -      ExprResult DefArgResult(ParseAssignmentExpression());<br>
> +      ExprResult DefArgResult;<br>
> +      if (Tok.is(tok::l_brace))<br>
> +        DefArgResult = ParseBraceInitializer();<br>
> +      else<br>
> +        DefArgResult = ParseAssignmentExpression();<br>
>       if (DefArgResult.isInvalid())<br>
>         Actions.ActOnParamDefaultArgumentError(LM.DefaultArgs[I].Param);<br>
>       else {<br>
><br>
> Modified: cfe/trunk/lib/Parse/ParseDecl.cpp<br>
> URL: <a href="http://llvm.org/viewvc/llvm-project/cfe/trunk/lib/Parse/ParseDecl.cpp?rev=152721&r1=152720&r2=152721&view=diff" target="_blank">http://llvm.org/viewvc/llvm-project/cfe/trunk/lib/Parse/ParseDecl.cpp?rev=152721&r1=152720&r2=152721&view=diff</a><br>

> ==============================================================================<br>
> --- cfe/trunk/lib/Parse/ParseDecl.cpp (original)<br>
> +++ cfe/trunk/lib/Parse/ParseDecl.cpp Wed Mar 14 10:54:00 2012<br>
> @@ -4169,6 +4169,7 @@<br>
>  ///       parameter-declaration: [C99 6.7.5]<br>
>  ///         declaration-specifiers declarator<br>
>  /// [C++]   declaration-specifiers declarator '=' assignment-expression<br>
> +/// [C++11]                                       initializer-clause<br>
>  /// [GNU]   declaration-specifiers declarator attributes<br>
>  ///         declaration-specifiers abstract-declarator[opt]<br>
>  /// [C++]   declaration-specifiers abstract-declarator[opt]<br>
> @@ -4280,7 +4281,11 @@<br>
>                                               Sema::PotentiallyEvaluatedIfUsed,<br>
>                                                 Param);<br>
><br>
> -          ExprResult DefArgResult(ParseAssignmentExpression());<br>
> +          ExprResult DefArgResult;<br>
> +          if (Tok.is(tok::l_brace))<br>
> +            DefArgResult = ParseBraceInitializer();<br>
> +          else<br>
> +            DefArgResult = ParseAssignmentExpression();<br>
<br>
</div></div>With this change, we accept "int f(int a = {1});" in C++98 mode<br>
without a warning.  That seems wrong.</blockquote><div><br></div><div>We should also produce a -Wc++98-compat warning for this in C++11 mode.</div></div>