<div class="gmail_quote">On Fri, Mar 9, 2012 at 12:02 PM, Daniel Dunbar <span dir="ltr"><<a href="mailto:daniel@zuster.org">daniel@zuster.org</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
Author: ddunbar<br>
Date: Fri Mar  9 14:02:47 2012<br>
New Revision: 152428<br>
<br>
URL: <a href="http://llvm.org/viewvc/llvm-project?rev=152428&view=rev" target="_blank">http://llvm.org/viewvc/llvm-project?rev=152428&view=rev</a><br>
Log:<br>
[Sema] Remove dead getSourceRange() call, caught by Clang after marking<br>
LLVM_READONLY.<br>
<br>
Modified:<br>
    cfe/trunk/lib/Sema/SemaExprCXX.cpp<br>
<br>
Modified: cfe/trunk/lib/Sema/SemaExprCXX.cpp<br>
URL: <a href="http://llvm.org/viewvc/llvm-project/cfe/trunk/lib/Sema/SemaExprCXX.cpp?rev=152428&r1=152427&r2=152428&view=diff" target="_blank">http://llvm.org/viewvc/llvm-project/cfe/trunk/lib/Sema/SemaExprCXX.cpp?rev=152428&r1=152427&r2=152428&view=diff</a><br>

==============================================================================<br>
--- cfe/trunk/lib/Sema/SemaExprCXX.cpp (original)<br>
+++ cfe/trunk/lib/Sema/SemaExprCXX.cpp Fri Mar  9 14:02:47 2012<br>
@@ -3566,8 +3566,7 @@<br>
           false).isInvalid())<br>
       return 0;<br>
     if (Value.isSigned() && Value.isNegative()) {<br>
-      Self.Diag(KeyLoc, diag::err_dimension_expr_not_constant_integer),<br>
-        DimExpr->getSourceRange();<br>
+      Self.Diag(KeyLoc, diag::err_dimension_expr_not_constant_integer);<br></blockquote><div><br></div><div>This was probably intended to be Self.Diag(...) << DimExpr->getSourceRange();</div></div>