<div class="gmail_quote">On Fri, Feb 24, 2012 at 1:07 AM, Nick Lewycky <span dir="ltr"><<a href="mailto:nicholas@mxc.ca">nicholas@mxc.ca</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
Author: nicholas<br>
Date: Fri Feb 24 03:07:53 2012<br>
New Revision: 151359<br>
<br>
URL: <a href="http://llvm.org/viewvc/llvm-project?rev=151359&view=rev" target="_blank">http://llvm.org/viewvc/llvm-project?rev=151359&view=rev</a><br>
Log:<br>
Revert r151357. That unreachable is reachable...<br>
<br>
Modified:<br>
    cfe/trunk/lib/AST/Expr.cpp<br>
<br>
Modified: cfe/trunk/lib/AST/Expr.cpp<br>
URL: <a href="http://llvm.org/viewvc/llvm-project/cfe/trunk/lib/AST/Expr.cpp?rev=151359&r1=151358&r2=151359&view=diff" target="_blank">http://llvm.org/viewvc/llvm-project/cfe/trunk/lib/AST/Expr.cpp?rev=151359&r1=151358&r2=151359&view=diff</a><br>

==============================================================================<br>
--- cfe/trunk/lib/AST/Expr.cpp (original)<br>
+++ cfe/trunk/lib/AST/Expr.cpp Fri Feb 24 03:07:53 2012<br>
@@ -499,28 +499,25 @@<br>
   return V.convertToDouble();<br>
 }<br>
<br>
-int StringLiteral::mapCharByteWidth(TargetInfo const &Target,<br>
-                                    StringKind Kind) {<br>
+int StringLiteral::mapCharByteWidth(TargetInfo const &target,StringKind k) {<br>
   int CharByteWidth;<br>
-  switch(Kind) {<br>
+  switch(k) {<br>
     case Ascii:<br>
     case UTF8:<br>
-      CharByteWidth = Target.getCharWidth();<br>
+      CharByteWidth = target.getCharWidth();<br>
       break;<br>
     case Wide:<br>
-      CharByteWidth = Target.getWCharWidth();<br>
+      CharByteWidth = target.getWCharWidth();<br>
       break;<br>
     case UTF16:<br>
-      CharByteWidth = Target.getChar16Width();<br>
+      CharByteWidth = target.getChar16Width();<br>
       break;<br>
     case UTF32:<br>
-      CharByteWidth = Target.getChar32Width();<br>
-    default:<br>
-      llvm_unreachable("Don't know byte width of this string kind!");<br>
+      CharByteWidth = target.getChar32Width();<br></blockquote><div><br></div><div>This is why we need a warning on switch case fallthrough :-)</div></div>