<html><head></head><body style="word-wrap: break-word; -webkit-nbsp-mode: space; -webkit-line-break: after-white-space; "><br><div><div>Le 7 févr. 2012 à 19:31, Matthieu Monrocq a écrit :</div><br class="Apple-interchange-newline"><blockquote type="cite"><br><br><div class="gmail_quote">Le 7 février 2012 19:01, Douglas Gregor <span dir="ltr"><<a href="mailto:dgregor@apple.com">dgregor@apple.com</a>></span> a écrit :<br><blockquote class="gmail_quote" style="margin-top: 0px; margin-right: 0px; margin-bottom: 0px; margin-left: 0.8ex; border-left-width: 1px; border-left-color: rgb(204, 204, 204); border-left-style: solid; padding-left: 1ex; position: static; z-index: auto; ">
<br>
On Feb 6, 2012, at 2:05 PM, Jean-Daniel Dupas wrote:<br>
<br>
> Ping.<br>
<br>
It looks okay, except that this:<br>
<br>
+ if (const NamedDecl *ND = dyn_cast<NamedDecl>(CE->getCalleeDecl())) {<br>
+ if (const FormatArgAttr *FA = ND->getAttr<FormatArgAttr>()) {<br>
<br>
assumes that CE->getCalleeDecl() can never return NULL. That's not generally the case, because the call could be a call to (say) a function pointer.<br>
<br>
- Doug<br></blockquote></div><br>Which in case you do not know, means that Doug says you should be using dyn_cast_or_null<> which checks for the nullity of the passed in argument.<br></blockquote><div><br></div><div>Thank you for the pointer :-)</div></div><div><br></div><div>Applied with the suggested change. (r149998)</div><br><div apple-content-edited="true">
<span class="Apple-style-span" style="border-collapse: separate; color: rgb(0, 0, 0); font-family: Helvetica; font-size: medium; font-style: normal; font-variant: normal; font-weight: normal; letter-spacing: normal; line-height: normal; orphans: 2; text-align: auto; text-indent: 0px; text-transform: none; white-space: normal; widows: 2; word-spacing: 0px; -webkit-border-horizontal-spacing: 0px; -webkit-border-vertical-spacing: 0px; -webkit-text-decorations-in-effect: none; -webkit-text-size-adjust: auto; -webkit-text-stroke-width: 0px; "><div>-- Jean-Daniel</div><div><br></div></span></div></body></html>