Could you please also extend the test (<span style>cfe/trunk/test/CodeGen/</span><span style>address-safety-attr.</span><span class="il" style>cpp</span>)?<div>Ok for me, but I'd prefer to have 'ok' from someone else on the clang side. <br>
<br>--kcc <br><br><div class="gmail_quote">On Tue, Jan 31, 2012 at 2:15 AM, Alexander Potapenko <span dir="ltr"><<a href="mailto:glider@google.com">glider@google.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
The attached patch moves the code that sets the AddressSafety<br>
attribute into CodeGenModule::SetLLVMFunctionAttributesForDefinition<br>
Previously it resided in CodeGenModule::GetOrCreateLLVMFunction, which<br>
for some reason wasn't called for ObjC class methods, see<br>
<a href="http://code.google.com/p/address-sanitizer/issues/detail?id=33" target="_blank">http://code.google.com/p/address-sanitizer/issues/detail?id=33</a><br>
<span class="HOEnZb"><font color="#888888"><br>
--<br>
Alexander Potapenko<br>
Software Engineer<br>
Google Moscow<br>
</font></span></blockquote></div><br></div>