<html><head></head><body style="word-wrap: break-word; -webkit-nbsp-mode: space; -webkit-line-break: after-white-space; "><div>LGTM!</div><br><div><div>On Jan 25, 2012, at 10:49 AM, Kaelyn Uhrain wrote:</div><br class="Apple-interchange-newline"><blockquote type="cite">Ping? I'd at least like someone more familiar with the parser to give this patch a once-over before committing it.<div><br></div><div>Thanks,</div><div>Kaelyn<br><br><div class="gmail_quote">On Mon, Jan 23, 2012 at 12:45 PM, <span dir="ltr"><<a href="mailto:rikka@google.com">rikka@google.com</a>></span> wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">Reviewers: <a href="http://kyrtzidis_apple.com/" target="_blank">kyrtzidis_apple.com</a>,<br>
<br>
Description:<br>
Pass a typo correction callback object from ParseCastExpr to<br>
Sema::ActOnIdExpression to be a bit more selective about what kinds of<br>
corrections will be allowed for unknown identifiers.<br>
<br>
Please review this at <a href="http://codereview.appspot.com/5572049/" target="_blank">http://codereview.appspot.com/<u></u>5572049/</a><br>
<br>
Affected files:<br>
M include/clang/Parse/Parser.h<br>
M include/clang/Sema/Sema.h<br>
M lib/Parse/ParseExpr.cpp<br>
M lib/Parse/ParseExprCXX.cpp<br>
M lib/Sema/SemaExpr.cpp<br>
M test/SemaCXX/typo-correction.<u></u>cpp<br>
<br>
<br>
</blockquote></div><br></div>
</blockquote></div><br></body></html>