<html><head></head><body style="word-wrap: break-word; -webkit-nbsp-mode: space; -webkit-line-break: after-white-space; "><br><div><div>On 20.01.2012, at 22:50, David Blaikie wrote:</div><br class="Apple-interchange-newline"><blockquote type="cite"><div>Author: dblaikie<br>Date: Fri Jan 20 15:50:17 2012<br>New Revision: 148577<br><br>URL: <a href="http://llvm.org/viewvc/llvm-project?rev=148577&view=rev">http://llvm.org/viewvc/llvm-project?rev=148577&view=rev</a><br>Log:<br>More dead code removal (using -Wunreachable-code)<br><br><br>Modified: cfe/trunk/lib/AST/Decl.cpp<br>URL: <a href="http://llvm.org/viewvc/llvm-project/cfe/trunk/lib/AST/Decl.cpp?rev=148577&r1=148576&r2=148577&view=diff">http://llvm.org/viewvc/llvm-project/cfe/trunk/lib/AST/Decl.cpp?rev=148577&r1=148576&r2=148577&view=diff</a><br>==============================================================================<br>--- cfe/trunk/lib/AST/Decl.cpp (original)<br>+++ cfe/trunk/lib/AST/Decl.cpp Fri Jan 20 15:50:17 2012<br>@@ -48,8 +48,6 @@<br> case VisibilityAttr::Protected:<br> return ProtectedVisibility;<br> }<br>-<br>- return DefaultVisibility;<br> }<br><br></div></blockquote><div><br></div><div>Should an llvm_unreachable should be added here?</div><div><br></div><blockquote type="cite"><div><font class="Apple-style-span" color="#000000"><br></font>Modified: cfe/trunk/lib/CodeGen/CGExprScalar.cpp<br>URL: <a href="http://llvm.org/viewvc/llvm-project/cfe/trunk/lib/CodeGen/CGExprScalar.cpp?rev=148577&r1=148576&r2=148577&view=diff">http://llvm.org/viewvc/llvm-project/cfe/trunk/lib/CodeGen/CGExprScalar.cpp?rev=148577&r1=148576&r2=148577&view=diff</a><br>==============================================================================<br>--- cfe/trunk/lib/CodeGen/CGExprScalar.cpp (original)<br>+++ cfe/trunk/lib/CodeGen/CGExprScalar.cpp Fri Jan 20 15:50:17 2012<br>@@ -2175,36 +2170,28 @@<br> case BuiltinType::UChar:<br> return (IT == VCMPEQ) ? llvm::Intrinsic::ppc_altivec_vcmpequb_p :<br> llvm::Intrinsic::ppc_altivec_vcmpgtub_p;<br>- break;<br> case BuiltinType::Char_S:<br> case BuiltinType::SChar:<br> return (IT == VCMPEQ) ? llvm::Intrinsic::ppc_altivec_vcmpequb_p :<br> llvm::Intrinsic::ppc_altivec_vcmpgtsb_p;<br>- break;<br> case BuiltinType::UShort:<br> return (IT == VCMPEQ) ? llvm::Intrinsic::ppc_altivec_vcmpequh_p :<br> llvm::Intrinsic::ppc_altivec_vcmpgtuh_p;<br>- break;<br> case BuiltinType::Short:<br> return (IT == VCMPEQ) ? llvm::Intrinsic::ppc_altivec_vcmpequh_p :<br> llvm::Intrinsic::ppc_altivec_vcmpgtsh_p;<br>- break;<br> case BuiltinType::UInt:<br> case BuiltinType::ULong:<br> return (IT == VCMPEQ) ? llvm::Intrinsic::ppc_altivec_vcmpequw_p :<br> llvm::Intrinsic::ppc_altivec_vcmpgtuw_p;<br>- break;<br> case BuiltinType::Int:<br> case BuiltinType::Long:<br> return (IT == VCMPEQ) ? llvm::Intrinsic::ppc_altivec_vcmpequw_p :<br> llvm::Intrinsic::ppc_altivec_vcmpgtsw_p;<br>- break;<br> case BuiltinType::Float:<br> return (IT == VCMPEQ) ? llvm::Intrinsic::ppc_altivec_vcmpeqfp_p :<br> llvm::Intrinsic::ppc_altivec_vcmpgtfp_p;<br>- break;<br> }<br>- return llvm::Intrinsic::not_intrinsic;<br> }<br></div></blockquote><div><br></div>And here.</div><div><br></div><div>Sebastian</div></body></html>