<div class="gmail_quote">On Thu, Jan 19, 2012 at 12:26 AM, James Molloy <span dir="ltr"><<a href="mailto:james.molloy@arm.com">james.molloy@arm.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
Hi Richard,<br>
<br>
Would it not also be worthwhile adding a case for -=? (and possibly *= / /=,<br>
but they're less common)<br></blockquote><div><br></div><div>I completely agree, we should fix this for all time. =] We should handle <<= and friends as well.</div><div><br></div><div>Specifically:</div><div><br class="Apple-interchange-newline">
On Wed, Jan 18, 2012 at 2:54 PM, Richard Trieu <span dir="ltr"><<a href="mailto:rtrieu@google.com">rtrieu@google.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin-top:0px;margin-right:0px;margin-bottom:0px;margin-left:0.8ex;border-left-width:1px;border-left-color:rgb(204,204,204);border-left-style:solid;padding-left:1ex">
<div id=":2lu">Modified: cfe/trunk/include/clang/Basic/DiagnosticParseKinds.td<br>URL: <a href="http://llvm.org/viewvc/llvm-project/cfe/trunk/include/clang/Basic/DiagnosticParseKinds.td?rev=148433&r1=148432&r2=148433&view=diff" target="_blank" class="cremed">http://llvm.org/viewvc/llvm-project/cfe/trunk/include/clang/Basic/DiagnosticParseKinds.td?rev=148433&r1=148432&r2=148433&view=diff</a><br>
==============================================================================<br>--- cfe/trunk/include/clang/Basic/DiagnosticParseKinds.td (original)<br>+++ cfe/trunk/include/clang/Basic/DiagnosticParseKinds.td Wed Jan 18 16:54:52 2012<br>
@@ -156,6 +156,8 @@<br>  "expected ';' after top level declarator">;<br> def err_invalid_equalequal_after_declarator : Error<<br>  "invalid '==' at end of declaration; did you mean '='?">;<br>
+def err_invalid_plusequal_after_declarator : Error<<br>+  "invalid '+=' at end of declaration; did you mean '='?">;</div></blockquote><div><br></div><div>Rather than two warnings here, lets generalize this by passing in the operator encountered as a string argument to the diagnostic message. Then the code to extend it becomes trivial.</div>
</div></div>