<html><head></head><body style="word-wrap: break-word; -webkit-nbsp-mode: space; -webkit-line-break: after-white-space; ">I found a little issue.<div><br></div><div>I was too much optimistic about CFString handling. Constant CFString are not string literals for clang, so trying to check them produce false diagnostic.</div><div>I removed CFString from the list of supported format.</div><div><br></div><div><div><div>Le 17 janv. 2012 à 06:31, Ted Kremenek a écrit :</div><br class="Apple-interchange-newline"><blockquote type="cite">
<div>
This looks great to me.
</div>
<div></div><p style="color: #A0A0A8;">On Monday, January 16, 2012 at 11:42 AM, Jean-Daniel Dupas wrote:</p>
<blockquote type="cite" style="border-left-style:solid;border-width:1px;margin-left:0px;padding-left:10px;">
<span><div><div><div>Le 14 janv. 2012 à 23:59, Jean-Daniel Dupas a écrit :</div><div><br></div><blockquote type="cite"><div><div>Hello,</div><div><br></div><div>Here is a patch to fix 2 issues:</div><div>- format strings attributes are not checked on obj-c methods.</div><div>- format attribute using NSString and CFString format are not checked at all.</div><div><br></div><div>This patch add a CheckObjCMethodCall() member to Sema that mirrors CheckFunctionCall() but work for obj-c method call and not function call.</div><div><br></div><div>To match the CheckFunctionCall() function, this new function handle "format" attributes (which was not handled yet), and "non null" attributes (which was previously handled in SemaObjC).</div><div><br></div><div>The second issue is that CheckablePrintfAttr() return true only if the format is printf, but should also returns true for NSString and CFString formats.</div><div><br></div><div>Please, can somebody review it, and apply it if it is fine.</div><div>Thanks.</div></div></blockquote><div><br></div><div>A second version of the patch.</div><div><br></div><div>Format attribute checking logic was copied at 3 places:</div><div>- in function call checking.</div><div>- in block call checking.</div><div>- in method call checking.</div><div><br></div><div>This new version of the patch factorizes the format checking logic in a single place: CheckFormatArguments()</div><div>It also fixes an inconsistency between CheckablePrintfAttr() and CheckPrintfScanfArguments().</div><div>The test to define if the attribute index should be shifted (if this is a C++ instance member call) was not correct in the former.</div><div>This test is now performed once.</div><div><br></div><div>Please, can somebody review it.</div><div>Thanks</div><div><br></div><div>-- Jean-Daniel</div></div><div><div>_______________________________________________</div><div>cfe-commits mailing list</div><div><a href="mailto:cfe-commits@cs.uiuc.edu">cfe-commits@cs.uiuc.edu</a></div><div><a href="http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits">http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits</a></div></div></div></span>
<div style="border-bottom: 1px solid #f0f0f0; height: 10px;">
</div>
<br>
<div style="font-weight: bold; font-size: 14px; margin-bottom: 5px;">Attachments:</div>
<div>
<div style="">- objc-format.patch</div>
</div>
</blockquote>
<div>
<br>
</div>
</blockquote></div><br><div>
<span class="Apple-style-span" style="border-collapse: separate; color: rgb(0, 0, 0); font-family: Helvetica; font-size: medium; font-style: normal; font-variant: normal; font-weight: normal; letter-spacing: normal; line-height: normal; orphans: 2; text-align: auto; text-indent: 0px; text-transform: none; white-space: normal; widows: 2; word-spacing: 0px; -webkit-border-horizontal-spacing: 0px; -webkit-border-vertical-spacing: 0px; -webkit-text-decorations-in-effect: none; -webkit-text-size-adjust: auto; -webkit-text-stroke-width: 0px; "><div>-- Jean-Daniel</div><div><br></div><div><br></div></span><br class="Apple-interchange-newline">
</div>
</div></body></html>