The testcase for this would be:<div><br></div><div><div>#include <stdio.h></div><div><br></div><div>void testcase(void) {</div><div>  vprintf(0, 0);</div><div>}</div><div><br></div><div>except that I will not introduce a test that isn't hermetic. It appears to be impossible to fake this by declaring my own function, or even using # lines to mark it. If I preprocess that testcase, the result no longer triggers the memory error.</div>


<div><br></div><div>Any suggestions for refactoring clang to make testing this possible would be greatly appreciated.</div><div><br></div><div>Nick</div><br><div class="gmail_quote">On 17 January 2012 19:41, Nick Lewycky <span dir="ltr"><<a href="mailto:nicholas@mxc.ca" target="_blank">nicholas@mxc.ca</a>></span> wrote:<br>


<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">Author: nicholas<br>
Date: Tue Jan 17 21:41:19 2012<br>
New Revision: 148375<br>
<br>
URL: <a href="http://llvm.org/viewvc/llvm-project?rev=148375&view=rev" target="_blank">http://llvm.org/viewvc/llvm-project?rev=148375&view=rev</a><br>
Log:<br>
Fix a string over-run detected by ASAN.<br>
<br>
Modified:<br>
    cfe/trunk/lib/CodeGen/CodeGenModule.cpp<br>
<br>
Modified: cfe/trunk/lib/CodeGen/CodeGenModule.cpp<br>
URL: <a href="http://llvm.org/viewvc/llvm-project/cfe/trunk/lib/CodeGen/CodeGenModule.cpp?rev=148375&r1=148374&r2=148375&view=diff" target="_blank">http://llvm.org/viewvc/llvm-project/cfe/trunk/lib/CodeGen/CodeGenModule.cpp?rev=148375&r1=148374&r2=148375&view=diff</a><br>



==============================================================================<br>
--- cfe/trunk/lib/CodeGen/CodeGenModule.cpp (original)<br>
+++ cfe/trunk/lib/CodeGen/CodeGenModule.cpp Tue Jan 17 21:41:19 2012<br>
@@ -883,8 +883,9 @@<br>
       unsigned BuiltinID = FD->getBuiltinID();<br>
       if (!BuiltinID)<br>
         return true;<br>
-      const char *BuiltinName = BI.GetName(BuiltinID) + strlen("__builtin_");<br>
-      if (Name == BuiltinName) {<br>
+      StringRef BuiltinName = BI.GetName(BuiltinID);<br>
+      if (BuiltinName.startswith("__builtin_") &&<br>
+          Name == BuiltinName.slice(strlen("__builtin_"), StringRef::npos)) {<br>
         Result = true;<br>
         return false;<br>
       }<br>
<br>
<br>
_______________________________________________<br>
cfe-commits mailing list<br>
<a href="mailto:cfe-commits@cs.uiuc.edu" target="_blank">cfe-commits@cs.uiuc.edu</a><br>
<a href="http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits" target="_blank">http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits</a><br>
</blockquote></div><br></div>