<div class="gmail_quote">On Mon, Jan 16, 2012 at 10:56 PM, David Blaikie <span dir="ltr"><<a href="mailto:dblaikie@gmail.com">dblaikie@gmail.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
<div id=":537">Modified: cfe/trunk/lib/Sema/SemaCodeComplete.cpp<br>
URL: <a href="http://llvm.org/viewvc/llvm-project/cfe/trunk/lib/Sema/SemaCodeComplete.cpp?rev=148292&r1=148291&r2=148292&view=diff" target="_blank" class="cremed">http://llvm.org/viewvc/llvm-project/cfe/trunk/lib/Sema/SemaCodeComplete.cpp?rev=148292&r1=148291&r2=148292&view=diff</a><br>

==============================================================================<br>
--- cfe/trunk/lib/Sema/SemaCodeComplete.cpp (original)<br>
+++ cfe/trunk/lib/Sema/SemaCodeComplete.cpp Tue Jan 17 00:56:22 2012<br>
@@ -596,8 +596,7 @@<br>
       default:<br>
         return STC_Arithmetic;<br>
     }<br>
-    return STC_Other;<br>
-<br>
+<br>
   case Type::Complex:<br>
     return STC_Arithmetic;<br>
<br>
@@ -1370,8 +1369,8 @@<br>
   case Sema::PCC_ForInit:<br>
     return LangOpts.CPlusPlus || LangOpts.ObjC1 || LangOpts.C99;<br>
   }<br>
-<br>
-  return false;<br>
+<br>
+  llvm_unreachable("Invalid ParserCompletionContext!");<br>
 }<br>
<br>
 static PrintingPolicy getCompletionPrintingPolicy(const ASTContext &Context,<br>
@@ -2793,7 +2792,7 @@<br>
     case Decl::ObjCCategory:       return CXCursor_ObjCCategoryDecl;<br>
     case Decl::ObjCCategoryImpl:   return CXCursor_ObjCCategoryImplDecl;<br>
       // FIXME<br>
-      return CXCursor_UnexposedDecl;<br>
+      // return CXCursor_UnexposedDecl;<br></div></blockquote><div><br></div><div><br></div><div>Based on the lines before this I don't think this is the right fix... The FIXME was that we represented ObjCCategory and ObjCCategoryImpl as UnexposedDecl; now that we don't it should just be deleted rather than commented out?</div>
</div>