<html><head></head><body style="word-wrap: break-word; -webkit-nbsp-mode: space; -webkit-line-break: after-white-space; "><br><div><div>On Dec 14, 2011, at 6:04 PM, Chandler Carruth wrote:</div><br class="Apple-interchange-newline"><blockquote type="cite"><div class="gmail_quote">On Wed, Dec 14, 2011 at 3:59 PM, Douglas Gregor <span dir="ltr"><<a href="mailto:dgregor@apple.com">dgregor@apple.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
<div id=":4pw">+/// \brief Determine whether two declarations declare the same entity.<br>
+inline bool declaresSameEntity(const Decl *D1, const Decl *D2) {<br>
+ if (D1 == D2)<br>
+ return true;<br>
+<br>
+ if (!D1 || !D2)<br>
+ return false;</div></blockquote></div><br><div>I find this very surprising. I would expect either being NULL to always return false... Was this intentional? If so, I would comment about it.</div>
</blockquote></div><div><br></div><div>It is weird. I've fixed it in r146659, thanks!</div><br><div><span class="Apple-tab-span" style="white-space:pre"> </span>- Doug</div></body></html>