<br><br><div class="gmail_quote">On Fri, Dec 9, 2011 at 1:40 PM, Douglas Gregor <span dir="ltr"><<a href="mailto:dgregor@apple.com">dgregor@apple.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin: 0px 0px 0px 0.8ex; padding-left: 1ex; border-left-color: rgb(204, 204, 204); border-left-width: 1px; border-left-style: solid;">
<div style="word-wrap: break-word;"><br><div><div><div class="h5"><div>On Dec 9, 2011, at 12:15 AM, David Blaikie wrote:</div><br><blockquote type="cite"><br><br><div class="gmail_quote">On Thu, Dec 8, 2011 at 8:01 PM, Matt Beaumont-Gay <span dir="ltr"><<a href="mailto:matthewbg@google.com" target="_blank">matthewbg@google.com</a>></span> wrote:<br>
<blockquote class="gmail_quote" style="margin: 0px 0px 0px 0.8ex; padding-left: 1ex; border-left-color: rgb(204, 204, 204); border-left-width: 1px; border-left-style: solid;">
<div>On Thu, Dec 8, 2011 at 19:43, David Blaikie <<a href="mailto:dblaikie@gmail.com" target="_blank">dblaikie@gmail.com</a>> wrote:<br>
> Just adding some finishing touches to Lang's recent excursion into the front<br>
> end by adding notes to describe how to suppress (and in simple cases, fix)<br>
> the warning<br>
><br>
> /tmp/webcompile/_7230_0.cc:3:10: warning: address of function 'f1' will<br>
> always evaluate to 'true' [-Wbool-conversions]<br>
> return f1;<br>
> ^~<br>
> /tmp/webcompile/_7230_0.cc:3:10: note: prefix with the address-of operator<br>
> to silence this warning<br>
> return f1;<br>
> ^<br>
> &<br>
> /tmp/webcompile/_7230_0.cc:3:10: note: suffix with parentheses to turn this<br>
> into a function call<br>
> return f1;<br>
> ^<br>
> ()<br>
><br>
> The latter note is only included if the function has a bool return and no<br>
> arguments (I couldn't figure out how to account for default or variadic<br>
> arguments - suggestions welcome. Also for bool conversion) so this is fairly<br>
> simple.<br>
<br>
</div>You might be interested in Sema::isExprCallable and Sema::tryToRecoverWithCall.<span><font color="#888888"><br></font></span></blockquote><div><br>Hey - thanks for the tip. That is really handy. It doesn't /seem/ to be doing much better than my first attempt (it doesn't seem to ever trigger the interesting case that uses FunctionDecl::getMinRequiredArguments - I'm still poking around with that. Perhaps this function can be generally improved for all callers) - and, curiously, the simple test cases I've tried ("struct foo { void bar(); }; int main() { foo f; f.bar; }") seem to have interesting behavior as you change whether the function is overloaded, callable, etc (it seems that the diagnostic caret location changes from f to bar, depending on that, among other things))<br>
</div></div></blockquote><div><br></div></div></div><div>This function could/should be improved, especially to make it cope with member functions better. </div><div> </div></div></div></blockquote><div> </div><div>I'll have a play around with it separately & see what I can come up with.</div>
<div> </div><blockquote class="gmail_quote" style="margin: 0px 0px 0px 0.8ex; padding-left: 1ex; border-left-color: rgb(204, 204, 204); border-left-width: 1px; border-left-style: solid;"><div style="word-wrap: break-word;">
<div><div> </div><div class="im"><br><blockquote type="cite"><div class="gmail_quote"><div>[updated with a version using isExprCallable - and also keeping the CC location in the warning that I'd previously removed </div>
</div></blockquote><div><br></div></div>LGTM!</div><div> </div></div></blockquote><div> </div><div>Thanks Doug! Committed as r146280</div><div> </div><blockquote class="gmail_quote" style="margin: 0px 0px 0px 0.8ex; padding-left: 1ex; border-left-color: rgb(204, 204, 204); border-left-width: 1px; border-left-style: solid;">
<div style="word-wrap: break-word;"><div> </div><div class="im"><div><br><blockquote type="cite"><div class="gmail_quote"><div>(but fixing its location by giving BinaryOperator a getExprLoc that provides the operator location which makes things read better - is that OK?)]<br>
</div></div></blockquote></div><br></div><div>Yes, that's a useful improvement.</div><div> </div></div></blockquote><div> </div><div>Great.</div><div> </div><div>Thanks again,</div><div>- David</div></div><br>