Good idea. Committed in r145534.<br><br><div>- Lang.<br><div><br><div class="gmail_quote">On Tue, Nov 29, 2011 at 8:24 PM, Nico Weber <span dir="ltr"><<a href="mailto:thakis@chromium.org">thakis@chromium.org</a>></span> wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex;">Test case? :-)<br>
<div class="HOEnZb"><div class="h5"><br>
On Tue, Nov 29, 2011 at 2:37 PM, Lang Hames <<a href="mailto:lhames@gmail.com">lhames@gmail.com</a>> wrote:<br>
> Author: lhames<br>
> Date: Tue Nov 29 16:37:13 2011<br>
> New Revision: 145441<br>
><br>
> URL: <a href="http://llvm.org/viewvc/llvm-project?rev=145441&view=rev" target="_blank">http://llvm.org/viewvc/llvm-project?rev=145441&view=rev</a><br>
> Log:<br>
> Test isa<FunctionDecl> to exclude objective-C methods. This ensures the following cast will never fail.<br>
><br>
> Modified:<br>
>    cfe/trunk/lib/Sema/SemaExpr.cpp<br>
><br>
> Modified: cfe/trunk/lib/Sema/SemaExpr.cpp<br>
> URL: <a href="http://llvm.org/viewvc/llvm-project/cfe/trunk/lib/Sema/SemaExpr.cpp?rev=145441&r1=145440&r2=145441&view=diff" target="_blank">http://llvm.org/viewvc/llvm-project/cfe/trunk/lib/Sema/SemaExpr.cpp?rev=145441&r1=145440&r2=145441&view=diff</a><br>

> ==============================================================================<br>
> --- cfe/trunk/lib/Sema/SemaExpr.cpp (original)<br>
> +++ cfe/trunk/lib/Sema/SemaExpr.cpp Tue Nov 29 16:37:13 2011<br>
> @@ -1592,7 +1592,7 @@<br>
>     // function definition declared at class scope then we must set<br>
>     // DC to the lexical parent to be able to search into the parent<br>
>     // class.<br>
> -    if (getLangOptions().MicrosoftMode && DC->isFunctionOrMethod() &&<br>
> +    if (getLangOptions().MicrosoftMode && isa<FunctionDecl>(DC) &&<br>
>         cast<FunctionDecl>(DC)->getFriendObjectKind() &&<br>
>         DC->getLexicalParent()->isRecord())<br>
>       DC = DC->getLexicalParent();<br>
><br>
><br>
> _______________________________________________<br>
> cfe-commits mailing list<br>
> <a href="mailto:cfe-commits@cs.uiuc.edu">cfe-commits@cs.uiuc.edu</a><br>
> <a href="http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits" target="_blank">http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits</a><br>
</div></div></blockquote></div><br></div></div>