<html><head></head><body style="word-wrap: break-word; -webkit-nbsp-mode: space; -webkit-line-break: after-white-space; "><br><div><div>On Nov 15, 2011, at 11:20 PM, Chandler Carruth wrote:</div><br class="Apple-interchange-newline"><blockquote type="cite"><div class="gmail_quote">On Tue, Nov 15, 2011 at 11:19 PM, Chandler Carruth <span dir="ltr"><<a href="mailto:chandlerc@google.com">chandlerc@google.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex;">
Sending this to Tanya and Doug; Bill is currently on vacation IIUC.<div><br></div><div>What do you folks think about including this in RC4? I have no strong opinions here. I don't know if MSVC building is really a goal of 3.0.</div>
</blockquote><div><br></div><div>For reference, This patch was mainline before RC3. I didn't realize how important it was, or I would have brought it up before.... But then no one else has complained about RC3 either, so I get the sense that no one is trying to build RC3 with MSVC….</div></div></blockquote><div><br></div>Do we not have any release testers building with MSVC? That would be a pretty big gap in our testing.</div><div><br></div><div>We should take this change; it's obviously well-tested, and it only affects CMake with MSVC, so the risk of breakage to anything critical is roughly zero.<br><br></div><div><span class="Apple-tab-span" style="white-space:pre"> </span>- Doug</div></body></html>