Sending this to Tanya and Doug; Bill is currently on vacation IIUC.<div><br></div><div>What do you folks think about including this in RC4? I have no strong opinions here. I don't know if MSVC building is really a goal of 3.0.<br>
<br><div class="gmail_quote">On Tue, Nov 15, 2011 at 11:00 PM, NAKAMURA Takumi <span dir="ltr"><<a href="mailto:geek4civic@gmail.com">geek4civic@gmail.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex;">
Bill please pick it up into release_30, or clang could not be built on msvc.<br>
<br>
2011/11/5 Michael J. Spencer <<a href="mailto:bigcheesegs@gmail.com">bigcheesegs@gmail.com</a>>:<br>
<div class="HOEnZb"><div class="h5">> Author: mspencer<br>
> Date: Fri Nov  4 19:46:46 2011<br>
> New Revision: 143770<br>
><br>
> URL: <a href="http://llvm.org/viewvc/llvm-project?rev=143770&view=rev" target="_blank">http://llvm.org/viewvc/llvm-project?rev=143770&view=rev</a><br>
> Log:<br>
> Fix MSVC build.<br>
><br>
> Modified:<br>
>    cfe/trunk/lib/Driver/CMakeLists.txt<br>
>    cfe/trunk/lib/Driver/ToolChains.cpp<br>
><br>
> Modified: cfe/trunk/lib/Driver/CMakeLists.txt<br>
> URL: <a href="http://llvm.org/viewvc/llvm-project/cfe/trunk/lib/Driver/CMakeLists.txt?rev=143770&r1=143769&r2=143770&view=diff" target="_blank">http://llvm.org/viewvc/llvm-project/cfe/trunk/lib/Driver/CMakeLists.txt?rev=143770&r1=143769&r2=143770&view=diff</a><br>

> ==============================================================================<br>
> --- cfe/trunk/lib/Driver/CMakeLists.txt (original)<br>
> +++ cfe/trunk/lib/Driver/CMakeLists.txt Fri Nov  4 19:46:46 2011<br>
> @@ -21,5 +21,13 @@<br>
>   Types.cpp<br>
>   )<br>
><br>
> +IF(MSVC)<br>
> +  get_target_property(NON_ANSI_COMPILE_FLAGS clangDriver COMPILE_FLAGS)<br>
> +  string(REPLACE /Za<br>
> +    "" NON_ANSI_COMPILE_FLAGS<br>
> +    ${NON_ANSI_COMPILE_FLAGS})<br>
> +  set_target_properties(clangDriver PROPERTIES COMPILE_FLAGS ${NON_ANSI_COMPILE_FLAGS})<br>
> +ENDIF(MSVC)<br>
> +<br>
>  add_dependencies(clangDriver ClangAttrList ClangDiagnosticDriver<br>
>                  ClangDriverOptions ClangCC1Options ClangCC1AsOptions)<br>
><br>
> Modified: cfe/trunk/lib/Driver/ToolChains.cpp<br>
> URL: <a href="http://llvm.org/viewvc/llvm-project/cfe/trunk/lib/Driver/ToolChains.cpp?rev=143770&r1=143769&r2=143770&view=diff" target="_blank">http://llvm.org/viewvc/llvm-project/cfe/trunk/lib/Driver/ToolChains.cpp?rev=143770&r1=143769&r2=143770&view=diff</a><br>

> ==============================================================================<br>
> --- cfe/trunk/lib/Driver/ToolChains.cpp (original)<br>
> +++ cfe/trunk/lib/Driver/ToolChains.cpp Fri Nov  4 19:46:46 2011<br>
> @@ -44,7 +44,9 @@<br>
>  // environment.<br>
>  #ifdef _MSC_VER<br>
>   #define WIN32_LEAN_AND_MEAN 1<br>
> -  #include <windows.h><br>
> +  #include <Windows.h><br>
> +  #undef min<br>
> +  #undef max<br>
>  #endif<br>
><br>
>  using namespace clang::driver;<br>
> @@ -2182,7 +2184,7 @@<br>
>     path = vsIDEInstallDir;<br>
>     return true;<br>
>   }<br>
> -<br>
> +<br>
>   if (hasVCExpressDir && vsExpressIDEInstallDir[0]) {<br>
>     char *p = (char*)strstr(vsExpressIDEInstallDir, "\\Common7\\IDE");<br>
>     if (p)<br>
><br>
><br>
> _______________________________________________<br>
> cfe-commits mailing list<br>
> <a href="mailto:cfe-commits@cs.uiuc.edu">cfe-commits@cs.uiuc.edu</a><br>
> <a href="http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits" target="_blank">http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits</a><br>
><br>
<br>
_______________________________________________<br>
cfe-commits mailing list<br>
<a href="mailto:cfe-commits@cs.uiuc.edu">cfe-commits@cs.uiuc.edu</a><br>
<a href="http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits" target="_blank">http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits</a><br>
</div></div></blockquote></div><br></div>