<html><head></head><body style="word-wrap: break-word; -webkit-nbsp-mode: space; -webkit-line-break: after-white-space; "><br><div><div>On Oct 4, 2011, at 9:52 AM, Ted Kremenek wrote:</div><br class="Apple-interchange-newline"><blockquote type="cite"><div style="word-wrap: break-word; -webkit-nbsp-mode: space; -webkit-line-break: after-white-space; "><div><div>On Oct 4, 2011, at 9:03 AM, Bob Wilson wrote:</div><br class="Apple-interchange-newline"><blockquote type="cite"><span class="Apple-style-span" style="border-collapse: separate; font-family: Helvetica; font-style: normal; font-variant: normal; font-weight: normal; letter-spacing: normal; line-height: normal; orphans: 2; text-align: -webkit-auto; text-indent: 0px; text-transform: none; white-space: normal; widows: 2; word-spacing: 0px; -webkit-border-horizontal-spacing: 0px; -webkit-border-vertical-spacing: 0px; -webkit-text-decorations-in-effect: none; -webkit-text-size-adjust: auto; -webkit-text-stroke-width: 0px; font-size: medium; ">I'm not sure this is a good idea. I understand the concern about having -W flags for all warnings, but we certainly don't anyone to start using -Wno-unsupported-debug-with-integrated-as.</span></blockquote><div><br></div><div>Can you clarify your concern? If people know what they are doing, they should be able to silence the warning (or promote them to an error).</div></div></div></blockquote><div><br></div>Yes, I guess it's a tradeoff. I'm just envisioning the scenario where someone is annoyed by this warning, changes a makefile to disable it, and then gets a build failure later when we remove the warning option. This warning is just a temporary hack to alert people to an unimplemented feature.</div><div><br><blockquote type="cite"><div style="word-wrap: break-word; -webkit-nbsp-mode: space; -webkit-line-break: after-white-space; "><div><br><blockquote type="cite"><span class="Apple-style-span" style="border-collapse: separate; font-family: Helvetica; font-style: normal; font-variant: normal; font-weight: normal; letter-spacing: normal; line-height: normal; orphans: 2; text-align: -webkit-auto; text-indent: 0px; text-transform: none; white-space: normal; widows: 2; word-spacing: 0px; -webkit-border-horizontal-spacing: 0px; -webkit-border-vertical-spacing: 0px; -webkit-text-decorations-in-effect: none; -webkit-text-size-adjust: auto; -webkit-text-stroke-width: 0px; font-size: medium; "> As soon as the integrated assembler can support debug info, we're going to rip out this warning, and we don't want to be stuck keeping the -W flags around for backward compatibility.</span></blockquote><div><br></div><div>I don't see that as an issue. We never promise that warnings will stay around forever. Once a warning is deemed not to be useful anymore we should feel free to remove it.</div><br><blockquote type="cite"><span class="Apple-style-span" style="border-collapse: separate; font-family: Helvetica; font-style: normal; font-variant: normal; font-weight: normal; letter-spacing: normal; line-height: normal; orphans: 2; text-align: -webkit-auto; text-indent: 0px; text-transform: none; white-space: normal; widows: 2; word-spacing: 0px; -webkit-border-horizontal-spacing: 0px; -webkit-border-vertical-spacing: 0px; -webkit-text-decorations-in-effect: none; -webkit-text-size-adjust: auto; -webkit-text-stroke-width: 0px; font-size: medium; "> Is there some existing warning group that we could use for this?</span></blockquote></div><br><div>No, and I don't think that would be the right approach anyway. That seems counter to your concern about putting this warning under a flag in the first place.</div><div><br></div><div>If you really don't want driver warnings to be under a -W flag, then we should consider adding another diagnostic category to segregate them from other warnings. Once we get all warnings under a -W flag, we'd like to change tablegen to reject warnings that are not in a diagnostic group.</div></div></blockquote><br></div><div>Right. I was wondering if we should have something like GCC's "notes" (maybe we already do?) But, then you still have the problem that someone may want to turn it off, so I don't think that's the right thing, either.</div><div><br></div><div>It's fine to leave this as it is. I think it's pretty unlikely that anyone is going to add -Wno-unsupported-debug-with-integrated-as to makefiles.</div></body></html>