<html><head></head><body style="word-wrap: break-word; -webkit-nbsp-mode: space; -webkit-line-break: after-white-space; "><br><div><div>On Sep 26, 2011, at 3:31 PM, Eli Friedman wrote:</div><br class="Apple-interchange-newline"><blockquote type="cite"><div>On Mon, Sep 26, 2011 at 3:12 PM, Fariborz Jahanian <<a href="mailto:fjahanian@apple.com">fjahanian@apple.com</a>> wrote:<br><blockquote type="cite">Author: fjahanian<br></blockquote><blockquote type="cite">Date: Mon Sep 26 17:12:27 2011<br></blockquote><blockquote type="cite">New Revision: 140571<br></blockquote><blockquote type="cite"><br></blockquote><blockquote type="cite">URL: <a href="http://llvm.org/viewvc/llvm-project?rev=140571&view=rev">http://llvm.org/viewvc/llvm-project?rev=140571&view=rev</a><br></blockquote><blockquote type="cite">Log:<br></blockquote><blockquote type="cite">objc - in matching setter argument type to its property type,<br></blockquote><blockquote type="cite">ingore the type qualifiers. // <a href="rdar://10156674">rdar://10156674</a><br></blockquote><blockquote type="cite"><br></blockquote><blockquote type="cite">Added:<br></blockquote><blockquote type="cite"> cfe/trunk/test/SemaObjC/arc-setter-property-match.m<br></blockquote><blockquote type="cite">Modified:<br></blockquote><blockquote type="cite"> cfe/trunk/lib/Sema/SemaObjCProperty.cpp<br></blockquote><blockquote type="cite"><br></blockquote><blockquote type="cite">Modified: cfe/trunk/lib/Sema/SemaObjCProperty.cpp<br></blockquote><blockquote type="cite">URL: <a href="http://llvm.org/viewvc/llvm-project/cfe/trunk/lib/Sema/SemaObjCProperty.cpp?rev=140571&r1=140570&r2=140571&view=diff">http://llvm.org/viewvc/llvm-project/cfe/trunk/lib/Sema/SemaObjCProperty.cpp?rev=140571&r1=140570&r2=140571&view=diff</a><br></blockquote><blockquote type="cite">==============================================================================<br></blockquote><blockquote type="cite">--- cfe/trunk/lib/Sema/SemaObjCProperty.cpp (original)<br></blockquote><blockquote type="cite">+++ cfe/trunk/lib/Sema/SemaObjCProperty.cpp Mon Sep 26 17:12:27 2011<br></blockquote><blockquote type="cite">@@ -1481,7 +1481,8 @@<br></blockquote><blockquote type="cite"> Context.VoidTy)<br></blockquote><blockquote type="cite"> Diag(SetterMethod->getLocation(), diag::err_setter_type_void);<br></blockquote><blockquote type="cite"> if (SetterMethod->param_size() != 1 ||<br></blockquote><blockquote type="cite">- ((*SetterMethod->param_begin())->getType() != property->getType())) {<br></blockquote><blockquote type="cite">+ ((*SetterMethod->param_begin())->getType().getUnqualifiedType()<br></blockquote><blockquote type="cite">+ != property->getType().getUnqualifiedType())) {<br></blockquote><blockquote type="cite"> Diag(property->getLocation(),<br></blockquote><blockquote type="cite"> diag::warn_accessor_property_type_mismatch)<br></blockquote><blockquote type="cite"> << property->getDeclName()<br></blockquote><br>ASTContext::hasSameUnqualifiedType might be useful here.<br></div></blockquote><div><br></div>Yes it is. In r140576.</div><div><br></div><div>- Thanks, Fariborz</div><div><br><blockquote type="cite"><div><br>-Eli<br><font class="Apple-style-span" color="#16761c"><br></font></div></blockquote></div><br></body></html>