<html><head></head><body bgcolor="#FFFFFF"><div>Go for it!<br><br>Sent from my iPhone</div><div><br>On Sep 21, 2011, at 12:42 PM, David Blaikie <<a href="mailto:dblaikie@gmail.com">dblaikie@gmail.com</a>> wrote:<br><br></div><div></div><blockquote type="cite"><div>I'm about to send out a patch to that effect. If someone (Doug, John, etc) wants to just say "yes" when they see that, I'll check it in.<br><br><div class="gmail_quote">On Wed, Sep 21, 2011 at 12:31 PM, Richard Trieu <span dir="ltr"><<a href="mailto:rtrieu@google.com">rtrieu@google.com</a>></span> wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex;"><div><div></div><div class="h5">On Wed, Sep 21, 2011 at 7:11 AM, Douglas Gregor <<a href="mailto:dgregor@apple.com">dgregor@apple.com</a>> wrote:<br>
><br>
> On Sep 20, 2011, at 7:50 PM, Richard Trieu wrote:<br>
><br>
>> Author: rtrieu<br>
>> Date: Tue Sep 20 21:50:14 2011<br>
>> New Revision: 140232<br>
>><br>
>> URL: <a href="http://llvm.org/viewvc/llvm-project?rev=140232&view=rev" target="_blank">http://llvm.org/viewvc/llvm-project?rev=140232&view=rev</a><br>
>> Log:<br>
>> Change:<br>
>><br>
>> assert(!"error message");<br>
>><br>
>> To:<br>
>><br>
>> assert(0 && "error message");<br>
>><br>
>> which is more consistant across the code base.<br>
>><br>
>> Modified:<br>
>> cfe/trunk/lib/Sema/SemaExpr.cpp<br>
>><br>
>> Modified: cfe/trunk/lib/Sema/SemaExpr.cpp<br>
>> URL: <a href="http://llvm.org/viewvc/llvm-project/cfe/trunk/lib/Sema/SemaExpr.cpp?rev=140232&r1=140231&r2=140232&view=diff" target="_blank">http://llvm.org/viewvc/llvm-project/cfe/trunk/lib/Sema/SemaExpr.cpp?rev=140232&r1=140231&r2=140232&view=diff</a><br>
>> ==============================================================================<br>
>> --- cfe/trunk/lib/Sema/SemaExpr.cpp (original)<br>
>> +++ cfe/trunk/lib/Sema/SemaExpr.cpp Tue Sep 20 21:50:14 2011<br>
>> @@ -8936,7 +8936,7 @@<br>
>> else if (pw == Context.getTargetInfo().getLongLongWidth())<br>
>> Ty = Context.LongLongTy;<br>
>> else {<br>
>> - assert(!"I don't know size of pointer!");<br>
>> + assert(0 && "I don't know size of pointer!");<br>
>> Ty = Context.IntTy;<br>
><br>
> Just use llvm_unreachable?<br>
><br>
> - Doug<br>
><br>
><br>
<br>
</div></div>Should all assert(0 && "error") be switched to llvm_unreachable("error") ?<br>
<div><div></div><div class="h5"><br>
_______________________________________________<br>
cfe-commits mailing list<br>
<a href="mailto:cfe-commits@cs.uiuc.edu">cfe-commits@cs.uiuc.edu</a><br>
<a href="http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits" target="_blank">http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits</a><br>
</div></div></blockquote></div><br>
</div></blockquote></body></html>