Looks good, please commit.<br><br><div class="gmail_quote">On Thu, Aug 18, 2011 at 8:56 AM, Manuel Klimek <span dir="ltr"><<a href="mailto:klimek@google.com">klimek@google.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex;">
RecursiveASTVisitor should call TraverseDecl(...) for every<br>
declaration it visits instead of directly calling the specialized<br>
traverse method.<br>
(also fixes a spelling error)<br>
<br>
diff --git a/include/clang/AST/RecursiveASTVisitor.h<br>
b/include/clang/AST/RecursiveASTVisitor.h<br>
index 8f593c1..473ba66 100644<br>
--- a/include/clang/AST/RecursiveASTVisitor.h<br>
+++ b/include/clang/AST/RecursiveASTVisitor.h<br>
@@ -1256,7 +1256,7 @@ bool<br>
RecursiveASTVisitor<Derived>::TraverseClassInstantiations(<br>
           = (U.get<ClassTemplatePartialSpecializationDecl*>() == Pattern);<br>
<br>
       if (ShouldVisit)<br>
-        TRY_TO(TraverseClassTemplateSpecializationDecl(SD));<br>
+        TRY_TO(TraverseDecl(SD));<br>
       break;<br>
     }<br>
<br>
@@ -1284,7 +1284,7 @@ DEF_TRAVERSE_DECL(ClassTemplateDecl, {<br>
     TRY_TO(TraverseTemplateParameterListHelper(D->getTemplateParameters()));<br>
<br>
     // By default, we do not traverse the instantiations of<br>
-    // class templates since they do not apprear in the user code. The<br>
+    // class templates since they do not appear in the user code. The<br>
     // following code optionally traverses them.<br>
     if (getDerived().shouldVisitTemplateInstantiations()) {<br>
       // If this is the definition of the primary template, visit<br>
<br>_______________________________________________<br>
cfe-commits mailing list<br>
<a href="mailto:cfe-commits@cs.uiuc.edu">cfe-commits@cs.uiuc.edu</a><br>
<a href="http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits" target="_blank">http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits</a><br>
<br></blockquote></div><br>