<html><head></head><body style="word-wrap: break-word; -webkit-nbsp-mode: space; -webkit-line-break: after-white-space; ">Looks great to me.<div><br><div><div>On Aug 10, 2011, at 6:09 PM, Richard Trieu wrote:</div><br class="Apple-interchange-newline"><blockquote type="cite">The current warning in -Wnull-arithmetic for comparisons between NULL and non-pointers is not very helpful. This patch will update the wording to be more helpful to users.<div><br></div><div>Old warning:</div><div><br></div>
<div><div>warning: use of NULL in arithmetic operation [-Wnull-arithmetic]</div><div> return 10 <= NULL;</div><div> ^ ~~~~</div></div><div><br></div><div>New warning:</div><div><br></div><div><div>warning: comparison between NULL and non-pointer ('int' and NULL) [-Wnull-arithmetic]</div>
<div> return 10 <= NULL;</div><div> ~~ ^ ~~~~</div></div><div><br></div><div>Patch attached and also available at <a href="http://codereview.appspot.com/4861041/">http://codereview.appspot.com/4861041/</a></div>
<span><null_comparison_warning.patch></span>_______________________________________________<br>cfe-commits mailing list<br><a href="mailto:cfe-commits@cs.uiuc.edu">cfe-commits@cs.uiuc.edu</a><br>http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits<br></blockquote></div><br></div></body></html>