<div class="gmail_quote">On Mon, Aug 8, 2011 at 6:39 PM, Richard Trieu <span dir="ltr"><<a href="mailto:rtrieu@google.com">rtrieu@google.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex;">
Refactoring of lib/Sema/SemaExpr.cpp broken into several patches.  Changes include reducing code duplication, moving diagnostic checks into separate functions, and reducing method length.  Comments welcome.
</blockquote></div><br><div>Uploaded to Rietveld.</div><div><br></div><div>Change to DiagnoseBitwisePrecedence()</div><div><a href="http://codereview.appspot.com/4830067/">http://codereview.appspot.com/4830067/</a></div>
<div><br></div><div>Refactor CheckAddressOfOperand()</div><div><a href="http://codereview.appspot.com/4856050/">http://codereview.appspot.com/4856050/</a></div><div><br></div><div>Consolidate shared code between Check (Addition, Subtract, IncrementDecrement) Operands()</div>
<div><a href="http://codereview.appspot.com/4832063/">http://codereview.appspot.com/4832063/</a></div><div><br></div><div>Reduce duplicate code in pointer comparisons</div><div><a href="http://codereview.appspot.com/4856049/">http://codereview.appspot.com/4856049/</a></div>
<div><br></div><div>Refactor UsualArithmeticConversions()<br></div><div><a href="http://codereview.appspot.com/4810092/">http://codereview.appspot.com/4810092/</a></div><div><br></div><div>Refactor CheckConditionalOperands()</div>
<div><a href="http://codereview.appspot.com/4859041/">http://codereview.appspot.com/4859041/</a></div><div><br></div><div>Move incomplete type in pointer arithmetic to new function</div><div><a href="http://codereview.appspot.com/4841059/">http://codereview.appspot.com/4841059/</a></div>
<div><br></div><div>Move null arithmetic check and different enum check to new functions</div><div><a href="http://codereview.appspot.com/4810091/">http://codereview.appspot.com/4810091/</a></div>