Hey Richard,<div><br></div><div>One more issue that I missed in the initial review (sorry about that)<br><br><div class="gmail_quote">On Wed, Jul 20, 2011 at 7:46 PM, Richard Trieu <span dir="ltr"><<a href="mailto:rtrieu@google.com">rtrieu@google.com</a>></span> wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex;"><div id=":dy6">- test0 = test0 ? EVal : (int) test0; // okay: EVal is an int<br>
- test0 = test0 ? // expected-warning {{operands of ? are integers of different signs}}<br>
+ test1 = test0 ? EVal : (int) test0;<br>
+ test0 = test0 ?<br>
(unsigned) EVal<br>
- : (int) test0;<br>
+ : (int) test0; // expected-warning {{operand of ? changes signedness: 'int' to 'unsigned long'}}</div></blockquote></div><br></div><div>Do we want to teach -Wsign-conversion to not warn about the conversion issue when both LHS and RHS have explicit casts? This seems like the only spot that's picking up a warning we didn't produce before...</div>