<html><head></head><body style="word-wrap: break-word; -webkit-nbsp-mode: space; -webkit-line-break: after-white-space; ">Hi Kaelyn,<div><br></div><div>Thanks for the statistics. What would be good to know is what fraction of these are false positives (i.e., are these all real bugs)? A small random sample might be helpful. A 24% increase in warnings is fairly substantial, and we don't want to do that unless there is a real benefit.</div><div><br></div><div>Ted</div><div><br><div><div>On Jul 18, 2011, at 5:18 PM, Kaelyn Uhrain wrote:</div><br class="Apple-interchange-newline"><blockquote type="cite"><div class="gmail_quote">Ted,<br><br>On Thu, Jul 14, 2011 at 5:04 PM, Ted Kremenek <span dir="ltr"><<a href="mailto:kremenek@apple.com">kremenek@apple.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex;">
<div style="word-wrap:break-word"><br><div>The only other issue: should this be controlled under a separate warning flag, at least initially so we can experiment with this new warning and see how noisy it is? E.g. "-Warray-bounds-pointer-arithmetic".</div>
</div></blockquote></div><br>I've tested the -Warray-bounds changes against the Google codebase and my patch increases the number of warnings from -Warray-bounds by 24%. Of the new warnings, 57.33% are for array indexes that most likely weren't picked up before because of unary operators like & or * (11.1% of all the warnings now emitted), and the remaining 42.67% are from out-of-bounds pointer arithmetic (8.3% of all the warnings from -Warray-bounds).<br>
<br>Cheers,<br>Kaelyn<br>
</blockquote></div><br></div></body></html>