<html><head></head><body style="word-wrap: break-word; -webkit-nbsp-mode: space; -webkit-line-break: after-white-space; "><br><div><div>On Jul 14, 2011, at 11:58 PM, Chandler Carruth wrote:</div><br class="Apple-interchange-newline"><blockquote type="cite"><div class="gmail_quote">On Thu, Jul 14, 2011 at 11:55 PM, Tobias Grosser <span dir="ltr"><<a href="mailto:tobias@grosser.es">tobias@grosser.es</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex;">
<div class="im">On 07/15/2011 08:47 AM, Chandler Carruth wrote:<br>
</div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div class="im">
It helps to attach the patch....<br>
<br>
On Thu, Jul 14, 2011 at 10:52 PM, Chandler Carruth <<a href="mailto:chandlerc@google.com" target="_blank">chandlerc@google.com</a><br></div><div class="im">
<mailto:<a href="mailto:chandlerc@google.com" target="_blank">chandlerc@google.com</a>>> wrote:<br>
<br>
I know next to nothing about the python bindings or how to test<br>
them, but I think this is the right patch. If someone who<br>
understands how this works can confirm, I'll commit...<br>
<br>
<br>
<br></div>
python-cindex-expansion.patch<br>
<br>
<br>
diff --git a/bindings/python/clang/<u></u>cindex.py b/bindings/python/clang/<u></u>cindex.py<br>
index 8cadcaa..a8d6ec6 100644<br>
--- a/bindings/python/clang/<u></u>cindex.py<br>
+++ b/bindings/python/clang/<u></u>cindex.py<br>
@@ -558,6 +558,7 @@ CursorKind.IB_OUTLET_<u></u>COLLECTION_ATTR = CursorKind(403)<br>
# Preprocessing<br>
CursorKind.PREPROCESSING_<u></u>DIRECTIVE = CursorKind(500)<br>
CursorKind.MACRO_DEFINITION = CursorKind(501)<br>
+CursorKind.MACRO_EXPANSION = CursorKind(502)<br>
CursorKind.MACRO_INSTANTIATION = CursorKind(502)<br>
</blockquote>
<br>
This does not seem correct to me. MACRO_EXPENSION and MACRO_INSTANTIATION have both the number 502.<br></blockquote><div><br></div><div>That's correct. INSTANTIATION is becoming EXPANSION. See my patch to libclang. There, we retain the old enum name (MACRO_INSTANTIATION) with the same value as a compatibility alias. That way existing code won't break.</div>
<div><br></div><div>If that approach isn't appropriate for the Python bindings, I'll just nuke the old name... wasn't sure what the best approach was here.</div></div></blockquote><br></div><div>It's fine just to nuke the old name in the Python bindings. Nobody depends on them, as far as I know.</div><div><br></div><div>Patch looks good, thanks for being thorough!</div><div><br></div><div><span class="Apple-tab-span" style="white-space:pre"> </span>- Doug</div><br></body></html>