<html><head></head><body style="word-wrap: break-word; -webkit-nbsp-mode: space; -webkit-line-break: after-white-space; ">All fair comments. I had similar reservations, and was borderline on reverting this myself.<div><br></div><div>The motivating example was something like</div><div><br></div><div> typedef unsigned long UInt32;</div><div><br></div><div>in a system header, but only for i386.</div><div><br></div><div>I'll revert.<br><div><br><div><div>On Jul 14, 2011, at 9:34 AM, David Blaikie wrote:</div><br class="Apple-interchange-newline"><blockquote type="cite">
<div class="gmail_quote"><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex;">I have to question the wisdom of this approach at all. Warnings should<br>
help to write good code, even if it may happen to work in a few cases.<br>
When int and long are the same size, then we have incorrect code that<br>
happens to work. I think we should leave this warning on and encourage<br>
users to make their code correct so that it doesn't break when they move<br>
to an LP64 environment.<br></blockquote><div><br>I tend to agree - I do have some amount of pain working with a compiler (MSVC) & on a team that produces multi-architecture binaries, getting warnings (when we use warnings-as-errors, and thus break the build) in certain flavors that aren't shown in others can be quite a pain. Though I can somewhat understand that people aren't necessarily used to such pedantry & this might need some way to differentiate itself as a different class of warning.<br>
<br>(one of the weirder ones I've seen on MSVC is that I don't get sign mismatch between size_t and int on 64 bit (I assume because size_t is 64 bit unsigned on a 64 bit build, so int can implicitly convert to a 64 bit unsigned value) but on 32 bit you get a sign mismatch warning/error/build break) <br>
<br>- David<br></div></div>
_______________________________________________<br>cfe-commits mailing list<br><a href="mailto:cfe-commits@cs.uiuc.edu">cfe-commits@cs.uiuc.edu</a><br>http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits<br></blockquote></div><br></div></div></body></html>