<html><head></head><body style="word-wrap: break-word; -webkit-nbsp-mode: space; -webkit-line-break: after-white-space; ">Hi Kaelyn,<div><br></div><div>This looks great. Nick already made some great comments on the code. If you could address the last couple review comments I think this is ready to push back to mainline.</div><div><br></div><div>Cheers,</div><div>Ted</div><div><br><div><div>On Jul 8, 2011, at 5:03 PM, Kaelyn Uhrain wrote:</div><br class="Apple-interchange-newline"><blockquote type="cite">The attached patch enhances the existing array bounds checking to include support for bounds checking on pointer arithmetic when possible (e.g. "Foo" + 5 or somearray - 7 when the size of somearray is known). It also fixes the bounds checking to work with unary operators like & and *; without this patch, for "char foo[4]", foo[15] would trigger the warning but &foo[15] wouldn't.<br>
<br>You can also view and comment on the changes at: <a href="http://codereview.appspot.com/4675068">http://codereview.appspot.com/4675068</a><br><br>Cheers,<br>Kaelyn<br>
_______________________________________________<br>cfe-commits mailing list<br><a href="mailto:cfe-commits@cs.uiuc.edu">cfe-commits@cs.uiuc.edu</a><br>http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits<br></blockquote></div><br></div></body></html>