<html><head></head><body style="word-wrap: break-word; -webkit-nbsp-mode: space; -webkit-line-break: after-white-space; "><br><div><div>On Jun 3, 2011, at 3:14 PM, Jonathan Turner wrote:</div><br class="Apple-interchange-newline"><blockquote type="cite"><div><br>On Jun 3, 2011, at 2:03 PM, Douglas Gregor wrote:<br><blockquote type="cite">+ // Source locations require array (variable-length) abbreviations. The<br></blockquote><blockquote type="cite">+ // abbreviation infrastructure requires that arrays are encoded last, so<br></blockquote><blockquote type="cite">+ // we handle it here in the case of those clases derived from DeclaratorDecl<br></blockquote><blockquote type="cite"><br></blockquote><blockquote type="cite">Typo "clases"<br></blockquote><br>Fixed.<br><br><blockquote type="cite">@@ -169,6 +176,20 @@<br></blockquote><blockquote type="cite">void ASTDeclWriter::VisitTypedefDecl(TypedefDecl *D) {<br></blockquote><blockquote type="cite"> VisitTypeDecl(D);<br></blockquote><blockquote type="cite"> Writer.AddTypeSourceInfo(D->getTypeSourceInfo(), Record);<br></blockquote><blockquote type="cite">+<br></blockquote><blockquote type="cite">+ if (!D->hasAttrs() &&<br></blockquote><blockquote type="cite">+ !D->isImplicit() &&<br></blockquote><blockquote type="cite">+ !D->isUsed(false) &&<br></blockquote><blockquote type="cite">+ D->getPCHLevel() == 0 &&<br></blockquote><blockquote type="cite">+ D->RedeclLink.getNext() == D &&<br></blockquote><blockquote type="cite">+ !D->isInvalidDecl() &&<br></blockquote><blockquote type="cite">+ !D->isReferenced() &&<br></blockquote><blockquote type="cite">+ D->getAccess() == AS_none &&<br></blockquote><blockquote type="cite">+ D->getDeclName().getNameKind() == DeclarationName::Identifier &&<br></blockquote><blockquote type="cite">+ D->getTypeSourceInfo())<br></blockquote><blockquote type="cite">+<br></blockquote><blockquote type="cite">+ AbbrevToUse = Writer.getDeclTypedefAbbrev();<br></blockquote><blockquote type="cite"><br></blockquote><blockquote type="cite">Do we actually need the D->getTypeSourceInfo() check here? It seems unnecessary.<br></blockquote><br>I'm being careful with any node types that use the TypeSourceInfo because the call to ASTWriter::AddTypeSourceInfo works differently if its first argument (which is D->getTypeSourceInfo() for us) is 0. <br></div></blockquote><div><br></div><div>Sure, but as long as it always puts *something* into the record, we should be fine.</div><br><blockquote type="cite"><div><font class="Apple-style-span" color="#00721d"><br></font>Done. Looks like I should have commit access now.<br></div></blockquote></div><br><div>Okay!</div><div><br></div><div><span class="Apple-tab-span" style="white-space:pre"> </span>- Doug</div></body></html>