<html><head></head><body style="word-wrap: break-word; -webkit-nbsp-mode: space; -webkit-line-break: after-white-space; "><br><div><br><div>Début du message réexpédié :</div><br class="Apple-interchange-newline"><blockquote type="cite"><div style="margin-top: 0px; margin-right: 0px; margin-bottom: 0px; margin-left: 0px;"><span style="font-family:'Helvetica'; font-size:medium; color:rgba(0, 0, 0, 1);"><b>De : </b></span><span style="font-family:'Helvetica'; font-size:medium;">Jean-Daniel Dupas <<a href="mailto:devlists@shadowlab.org">devlists@shadowlab.org</a>><br></span></div><div style="margin-top: 0px; margin-right: 0px; margin-bottom: 0px; margin-left: 0px;"><span style="font-family:'Helvetica'; font-size:medium; color:rgba(0, 0, 0, 1);"><b>Date : </b></span><span style="font-family:'Helvetica'; font-size:medium;">26 avril 2011 09:53:42 HAEC<br></span></div><div style="margin-top: 0px; margin-right: 0px; margin-bottom: 0px; margin-left: 0px;"><span style="font-family:'Helvetica'; font-size:medium; color:rgba(0, 0, 0, 1);"><b>À : </b></span><span style="font-family:'Helvetica'; font-size:medium;">Peter Collingbourne <<a href="mailto:peter@pcc.me.uk">peter@pcc.me.uk</a>><br></span></div><div style="margin-top: 0px; margin-right: 0px; margin-bottom: 0px; margin-left: 0px;"><span style="font-family:'Helvetica'; font-size:medium; color:rgba(0, 0, 0, 1);"><b>Cc : </b></span><span style="font-family:'Helvetica'; font-size:medium;"><a href="mailto:cfe-commits@cs.uiuc.edu">cfe-commits@cs.uiuc.edu</a><br></span></div><div style="margin-top: 0px; margin-right: 0px; margin-bottom: 0px; margin-left: 0px;"><span style="font-family:'Helvetica'; font-size:medium; color:rgba(0, 0, 0, 1);"><b>Objet : </b></span><span style="font-family:'Helvetica'; font-size:medium;"><b>Rép : [cfe-commits] [PATCH] _has_feature support for new C1X features.</b><br></span></div><br><div><br>Le 26 avr. 2011 à 01:02, Peter Collingbourne a écrit :<br><br><blockquote type="cite">On Mon, Apr 25, 2011 at 09:15:09PM +0200, Jean-Daniel Dupas wrote:<br></blockquote><blockquote type="cite"><blockquote type="cite">As clang start to implements C1X, it may be useful to extend __has_feature to support the new implemented features.<br></blockquote></blockquote><blockquote type="cite"><blockquote type="cite"><br></blockquote></blockquote><blockquote type="cite"><blockquote type="cite">Here is a patch that add 'c_static_assert' and 'c_generic_selection', and a test case similar to the one used for c++0x.<br></blockquote></blockquote><blockquote type="cite"><blockquote type="cite"><br></blockquote></blockquote><blockquote type="cite"><blockquote type="cite">This patch adds 'c_generic_selection', but I don't know the status of this feature. If it is not ready yet, this part should be commented.<br></blockquote></blockquote><blockquote type="cite"><br></blockquote><blockquote type="cite">Hi Jean-Daniel,<br></blockquote><blockquote type="cite"><br></blockquote><blockquote type="cite">We already have __has_feature(generic_selections).<br></blockquote><br>My bad, I missed it.<br>I moved it next to "static_assert", so it would be easier to find what C1X extensions are already declared here.<br><br><blockquote type="cite">Prefixing C features with c_ is unprecedented (and it would of course<br></blockquote><blockquote type="cite">be a bad idea to rename the existing C features/extensions) so I think<br></blockquote><blockquote type="cite">that for the sake of consistency the C1X static assert feature should<br></blockquote><blockquote type="cite">just be called "static_assert".<br></blockquote><br>Of course, it would definitively be better to keep it consistent.<br><br><blockquote type="cite">Also, C1X static assertions are supported as an extension in all<br></blockquote><blockquote type="cite">languages so the feature should not be predicated on the C1X language<br></blockquote><blockquote type="cite">option.<br></blockquote><br><br>Here is a patch that simply add "static_assert" and declare it enabled unconditionally.<br><br></div></blockquote><div><br></div><div><br></div><div>Is there someone to review (and apply) this minor change ? </div><br><blockquote type="cite"><div><br><br></div></blockquote></div></body></html>