<html><head></head><body style="word-wrap: break-word; -webkit-nbsp-mode: space; -webkit-line-break: after-white-space; ">Anton,<div><br></div><div>This patch breaks following tests on i386-darwin10</div><div><span class="Apple-style-span" style="font-family: 'Courier New', courier, monotype; white-space: pre; "><br></span></div><div><span class="Apple-style-span" style="font-family: 'Courier New', courier, monotype; white-space: pre; ">SingleSource/UnitTests/ObjC++/property-reference-object.compile</span></div><div><span class="Apple-style-span" style="font-family: 'Courier New', courier, monotype; white-space: pre; "></span><span class="Apple-style-span" style="font-family: 'Courier New', courier, monotype; white-space: pre; ">SingleSource/UnitTests/ObjC++/property-reference-object.exec</span></div><div><div><br></div></div><div>Can you take a look ?</div><div>Thanks,</div><div>-</div><div>Devang</div><div><div><div>On Mar 28, 2011, at 2:00 PM, Anton Yartsev wrote:</div><br class="Apple-interchange-newline"><blockquote type="cite"><div>Author: ayartsev<br>Date: Mon Mar 28 16:00:05 2011<br>New Revision: 128427<br><br>URL: <a href="http://llvm.org/viewvc/llvm-project?rev=128427&view=rev">http://llvm.org/viewvc/llvm-project?rev=128427&view=rev</a><br>Log:<br>refactoring<br><br>Modified:<br> cfe/trunk/lib/CodeGen/CGExprScalar.cpp<br> cfe/trunk/lib/Sema/SemaExpr.cpp<br><br>Modified: cfe/trunk/lib/CodeGen/CGExprScalar.cpp<br>URL: <a href="http://llvm.org/viewvc/llvm-project/cfe/trunk/lib/CodeGen/CGExprScalar.cpp?rev=128427&r1=128426&r2=128427&view=diff">http://llvm.org/viewvc/llvm-project/cfe/trunk/lib/CodeGen/CGExprScalar.cpp?rev=128427&r1=128426&r2=128427&view=diff</a><br>==============================================================================<br>--- cfe/trunk/lib/CodeGen/CGExprScalar.cpp (original)<br>+++ cfe/trunk/lib/CodeGen/CGExprScalar.cpp Mon Mar 28 16:00:05 2011<br>@@ -2119,9 +2119,7 @@<br><br> // If AltiVec, the comparison results in a numeric type, so we use<br> // intrinsics comparing vectors and giving 0 or 1 as a result<br>- if (LHSTy->isVectorType() &&<br>- LHSTy->getAs<VectorType>()->getVectorKind() ==<br>- VectorType::AltiVecVector) {<br>+ if (LHSTy->isVectorType() && !E->getType()->isVectorType()) {<br> // constants for mapping CR6 register bits to predicate result<br> enum { CR6_EQ=0, CR6_EQ_REV, CR6_LT, CR6_LT_REV } CR6;<br><br><br>Modified: cfe/trunk/lib/Sema/SemaExpr.cpp<br>URL: <a href="http://llvm.org/viewvc/llvm-project/cfe/trunk/lib/Sema/SemaExpr.cpp?rev=128427&r1=128426&r2=128427&view=diff">http://llvm.org/viewvc/llvm-project/cfe/trunk/lib/Sema/SemaExpr.cpp?rev=128427&r1=128426&r2=128427&view=diff</a><br>==============================================================================<br>--- cfe/trunk/lib/Sema/SemaExpr.cpp (original)<br>+++ cfe/trunk/lib/Sema/SemaExpr.cpp Mon Mar 28 16:00:05 2011<br>@@ -7282,9 +7282,7 @@<br><br> // If AltiVec, the comparison results in a numeric type, i.e.<br> // bool for C++, int for C<br>- if (lType->getAs<VectorType>()->getVectorKind() == VectorType::AltiVecVector<br>- && rType->getAs<VectorType>()->getVectorKind() ==<br>- VectorType::AltiVecVector)<br>+ if (vType->getAs<VectorType>()->getVectorKind() == VectorType::AltiVecVector)<br> return Context.getLogicalOperationType();<br><br> // For non-floating point types, check for self-comparisons of the form<br><br><br>_______________________________________________<br>cfe-commits mailing list<br><a href="mailto:cfe-commits@cs.uiuc.edu">cfe-commits@cs.uiuc.edu</a><br>http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits<br></div></blockquote></div><br></div></body></html>