<html><head></head><body style="word-wrap: break-word; -webkit-nbsp-mode: space; -webkit-line-break: after-white-space; "><br><div><div>On Feb 15, 2011, at 7:16 PM, Chandler Carruth wrote:</div><br class="Apple-interchange-newline"><blockquote type="cite"><span class="Apple-style-span" style="border-collapse: separate; font-family: Helvetica; font-style: normal; font-variant: normal; font-weight: normal; letter-spacing: normal; line-height: normal; orphans: 2; text-indent: 0px; text-transform: none; white-space: normal; widows: 2; word-spacing: 0px; -webkit-border-horizontal-spacing: 0px; -webkit-border-vertical-spacing: 0px; -webkit-text-decorations-in-effect: none; -webkit-text-size-adjust: auto; -webkit-text-stroke-width: 0px; font-size: medium; ">On Tue, Feb 15, 2011 at 5:57 PM, Ted Kremenek<span class="Apple-converted-space"> </span><span dir="ltr"><<a href="mailto:kremenek@apple.com">kremenek@apple.com</a>></span><span class="Apple-converted-space"> </span>wrote:<br><blockquote class="gmail_quote" style="margin-top: 0px; margin-right: 0px; margin-bottom: 0px; margin-left: 0.8ex; border-left-width: 1px; border-left-color: rgb(204, 204, 204); border-left-style: solid; padding-left: 1ex; ">Author: kremenek<br>Date: Tue Feb 15 19:57:07 2011<br>New Revision: 125640<br><br>URL:<span class="Apple-converted-space"> </span><a href="http://llvm.org/viewvc/llvm-project?rev=125640&view=rev" target="_blank">http://llvm.org/viewvc/llvm-project?rev=125640&view=rev</a><br>Log:<br>Add trivial buffer overflow checking in Sema.<br></blockquote><div><br></div><div>Totally psyched about this, but a little sad too. =] We just implemented this, and were polishing before sending it for review. Also, this is tracked in PR9098.</div></span></blockquote><div><br></div><div>No need to be sad. We should just put whatever is the best implementation into Clang. If that includes scrapping what I spent an hour working on, then that's fine. :)</div><div><br></div><blockquote type="cite"><span class="Apple-style-span" style="border-collapse: separate; font-family: Helvetica; font-style: normal; font-variant: normal; font-weight: normal; letter-spacing: normal; line-height: normal; orphans: 2; text-indent: 0px; text-transform: none; white-space: normal; widows: 2; word-spacing: 0px; -webkit-border-horizontal-spacing: 0px; -webkit-border-vertical-spacing: 0px; -webkit-text-decorations-in-effect: none; -webkit-text-size-adjust: auto; -webkit-text-stroke-width: 0px; font-size: medium; "><div><br></div><div>Also:</div><div><br></div><blockquote class="gmail_quote" style="margin-top: 0px; margin-right: 0px; margin-bottom: 0px; margin-left: 0.8ex; border-left-width: 1px; border-left-color: rgb(204, 204, 204); border-left-style: solid; padding-left: 1ex; position: static; z-index: auto; ">+def warn_array_index_out_of_bounds : Warning<<br>+ "array index %select{precedes first|excedes last}0 array element">,<br></blockquote><div><br></div><div>Spelling of 'excedes'? ;]</div></span></blockquote><div><br></div><div>Ha!</div><br><blockquote type="cite"><span class="Apple-style-span" style="border-collapse: separate; font-family: Helvetica; font-style: normal; font-variant: normal; font-weight: normal; letter-spacing: normal; line-height: normal; orphans: 2; text-indent: 0px; text-transform: none; white-space: normal; widows: 2; word-spacing: 0px; -webkit-border-horizontal-spacing: 0px; -webkit-border-vertical-spacing: 0px; -webkit-text-decorations-in-effect: none; -webkit-text-size-adjust: auto; -webkit-text-stroke-width: 0px; font-size: medium; "><div><br></div><div>Also, maybe phrase this as "is negative" and "past the end"?</div></span></blockquote><div><br></div><div>I don't think we need 'is negative' if we print out the value. That's obvious. Rather, I think we should focus on the implication (like, "past the end" as you suggest).</div><div><br></div><blockquote type="cite"><span class="Apple-style-span" style="border-collapse: separate; font-family: Helvetica; font-style: normal; font-variant: normal; font-weight: normal; letter-spacing: normal; line-height: normal; orphans: 2; text-indent: 0px; text-transform: none; white-space: normal; widows: 2; word-spacing: 0px; -webkit-border-horizontal-spacing: 0px; -webkit-border-vertical-spacing: 0px; -webkit-text-decorations-in-effect: none; -webkit-text-size-adjust: auto; -webkit-text-stroke-width: 0px; font-size: medium; "><div> When we implemented it we included the actual index given (or computed), and attached a note for cases where we have a declaration of the array with a fixed size.</div></span></blockquote><br></div><div>I've incorporated these suggestions in r125649. We now:</div><div><br></div><div>- print out the index</div><div>- print out the number of elements in the array (if we exceed the array size)</div><div>- have a note referencing the declaration of the array</div><div><br></div><div><br></div><div><br></div><br></body></html>