lol.<br><br><div class="gmail_quote">On Sat, Jan 15, 2011 at 1:41 PM, Ted Kremenek <span dir="ltr"><<a href="mailto:kremenek@apple.com">kremenek@apple.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin: 0pt 0pt 0pt 0.8ex; border-left: 1px solid rgb(204, 204, 204); padding-left: 1ex;">
I think we only need to worry when it starts learning at a geometric rate... :)<br>
<div><div></div><div class="h5"><br>
On Jan 14, 2011, at 4:29 PM, Argyrios Kyrtzidis <<a href="mailto:kyrtzidis@apple.com">kyrtzidis@apple.com</a>> wrote:<br>
<br>
> The static analyzer is finding issues in the static analyzer, omg it's becoming self-aware like skynet!!!1!1one<br>
><br>
> -Argiris<br>
><br>
> On Jan 14, 2011, at 2:31 PM, Ted Kremenek wrote:<br>
><br>
>> Author: kremenek<br>
>> Date: Fri Jan 14 16:31:41 2011<br>
>> New Revision: 123485<br>
>><br>
>> URL: <a href="http://llvm.org/viewvc/llvm-project?rev=123485&view=rev" target="_blank">http://llvm.org/viewvc/llvm-project?rev=123485&view=rev</a><br>
>> Log:<br>
>> Cleanup confused code that redundantly called "getDeclContext()" twice.<br>
>> Found by clang static analyzer.<br>
>><br>
>> Modified:<br>
>>   cfe/trunk/lib/StaticAnalyzer/Checkers/LLVMConventionsChecker.cpp<br>
>><br>
>> Modified: cfe/trunk/lib/StaticAnalyzer/Checkers/LLVMConventionsChecker.cpp<br>
>> URL: <a href="http://llvm.org/viewvc/llvm-project/cfe/trunk/lib/StaticAnalyzer/Checkers/LLVMConventionsChecker.cpp?rev=123485&r1=123484&r2=123485&view=diff" target="_blank">http://llvm.org/viewvc/llvm-project/cfe/trunk/lib/StaticAnalyzer/Checkers/LLVMConventionsChecker.cpp?rev=123485&r1=123484&r2=123485&view=diff</a><br>

>> ==============================================================================<br>
>> --- cfe/trunk/lib/StaticAnalyzer/Checkers/LLVMConventionsChecker.cpp (original)<br>
>> +++ cfe/trunk/lib/StaticAnalyzer/Checkers/LLVMConventionsChecker.cpp Fri Jan 14 16:31:41 2011<br>
>> @@ -38,15 +38,13 @@<br>
>> /// Check whether the declaration is semantically inside the top-level<br>
>> /// namespace named by ns.<br>
>> static bool InNamespace(const Decl *D, llvm::StringRef NS) {<br>
>> -  const DeclContext *DC = D->getDeclContext();<br>
>>  const NamespaceDecl *ND = dyn_cast<NamespaceDecl>(D->getDeclContext());<br>
>>  if (!ND)<br>
>>    return false;<br>
>>  const IdentifierInfo *II = ND->getIdentifier();<br>
>>  if (!II || !II->getName().equals(NS))<br>
>>    return false;<br>
>> -  DC = ND->getDeclContext();<br>
>> -  return isa<TranslationUnitDecl>(DC);<br>
>> +  return isa<TranslationUnitDecl>(ND->getDeclContext());<br>
>> }<br>
>><br>
>> static bool IsStdString(QualType T) {<br>
>><br>
>><br>
>> _______________________________________________<br>
>> cfe-commits mailing list<br>
>> <a href="mailto:cfe-commits@cs.uiuc.edu">cfe-commits@cs.uiuc.edu</a><br>
>> <a href="http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits" target="_blank">http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits</a><br>
><br>
_______________________________________________<br>
cfe-commits mailing list<br>
<a href="mailto:cfe-commits@cs.uiuc.edu">cfe-commits@cs.uiuc.edu</a><br>
<a href="http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits" target="_blank">http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits</a><br>
</div></div></blockquote></div><br><div style="visibility: hidden; left: -5000px; position: absolute; z-index: 9999; padding: 0px; margin-left: 0px; margin-top: 0px; overflow: hidden; word-wrap: break-word; color: black; font-size: 10px; text-align: left; line-height: 130%;" id="avg_ls_inline_popup">
</div>