No. I want to reduce the uses of StripCasts. It shouldn't be used everywhere. Here we should check the zero index explicitly.<br><br><div class="gmail_quote">On Sun, Nov 28, 2010 at 3:45 PM, Ted Kremenek <span dir="ltr"><<a href="mailto:kremenek@apple.com">kremenek@apple.com</a>></span> wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex;">Hi Zhongxing,<br>
<br>
What is the motivation for this change?  Did the previous logic cause a test case to fail?<br>
<div><div></div><div class="h5"><br>
On Nov 26, 2010, at 1:07 AM, Zhongxing Xu <<a href="mailto:xuzhongxing@gmail.com">xuzhongxing@gmail.com</a>> wrote:<br>
<br>
> Author: zhongxingxu<br>
> Date: Fri Nov 26 03:07:38 2010<br>
> New Revision: 120177<br>
><br>
> URL: <a href="http://llvm.org/viewvc/llvm-project?rev=120177&view=rev" target="_blank">http://llvm.org/viewvc/llvm-project?rev=120177&view=rev</a><br>
> Log:<br>
> Should not use StripCasts() in this context.<br>
><br>
> Modified:<br>
>    cfe/trunk/lib/Checker/ReturnPointerRangeChecker.cpp<br>
><br>
> Modified: cfe/trunk/lib/Checker/ReturnPointerRangeChecker.cpp<br>
> URL: <a href="http://llvm.org/viewvc/llvm-project/cfe/trunk/lib/Checker/ReturnPointerRangeChecker.cpp?rev=120177&r1=120176&r2=120177&view=diff" target="_blank">http://llvm.org/viewvc/llvm-project/cfe/trunk/lib/Checker/ReturnPointerRangeChecker.cpp?rev=120177&r1=120176&r2=120177&view=diff</a><br>

> ==============================================================================<br>
> --- cfe/trunk/lib/Checker/ReturnPointerRangeChecker.cpp (original)<br>
> +++ cfe/trunk/lib/Checker/ReturnPointerRangeChecker.cpp Fri Nov 26 03:07:38 2010<br>
> @@ -48,19 +48,16 @@<br>
><br>
>   SVal V = state->getSVal(RetE);<br>
>   const MemRegion *R = V.getAsRegion();<br>
> -  if (!R)<br>
> -    return;<br>
> -<br>
> -  R = R->StripCasts();<br>
> -  if (!R)<br>
> -    return;<br>
><br>
>   const ElementRegion *ER = dyn_cast_or_null<ElementRegion>(R);<br>
>   if (!ER)<br>
>     return;<br>
><br>
>   DefinedOrUnknownSVal Idx = cast<DefinedOrUnknownSVal>(ER->getIndex());<br>
> -<br>
> +  // Zero index is always in bound, this also passes ElementRegions created for<br>
> +  // pointer casts.<br>
> +  if (Idx.isZeroConstant())<br>
> +    return;<br>
>   // FIXME: All of this out-of-bounds checking should eventually be refactored<br>
>   // into a common place.<br>
><br>
><br>
><br>
> _______________________________________________<br>
> cfe-commits mailing list<br>
> <a href="mailto:cfe-commits@cs.uiuc.edu">cfe-commits@cs.uiuc.edu</a><br>
> <a href="http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits" target="_blank">http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits</a><br>
</div></div></blockquote></div><br>