W dniu 17 listopada 2010 12:08 użytkownik Zhongxing Xu <span dir="ltr"><<a href="mailto:xuzhongxing@gmail.com">xuzhongxing@gmail.com</a>></span> napisał:<br><div class="gmail_quote"><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex;">
<br><br><div class="gmail_quote">2010/11/17 Marcin Świderski <span dir="ltr"><<a href="mailto:marcin.sfider@gmail.com" target="_blank">marcin.sfider@gmail.com</a>></span><div class="im"><br><blockquote class="gmail_quote" style="margin:0pt 0pt 0pt 0.8ex;border-left:1px solid rgb(204, 204, 204);padding-left:1ex">
2010/11/17 Zhongxing Xu <span dir="ltr"><<a href="mailto:xuzhongxing@gmail.com" target="_blank">xuzhongxing@gmail.com</a>></span><br><div class="gmail_quote"><div><blockquote class="gmail_quote" style="margin:0pt 0pt 0pt 0.8ex;border-left:1px solid rgb(204, 204, 204);padding-left:1ex">
<div class="gmail_quote"><div>On Tue, Nov 16, 2010 at 4:50 PM, Marcin Swiderski <span dir="ltr"><<a href="mailto:marcin.sfider@gmail.com" target="_blank">marcin.sfider@gmail.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0pt 0pt 0pt 0.8ex;border-left:1px solid rgb(204, 204, 204);padding-left:1ex">
Author: sfider<br>
Date: Tue Nov 16 02:50:38 2010<br>
New Revision: 119341<br>
<br>
URL: <a href="http://llvm.org/viewvc/llvm-project?rev=119341&view=rev" target="_blank">http://llvm.org/viewvc/llvm-project?rev=119341&view=rev</a><br>
Log:<br>
Refactored GRExprEngine::getCXXThisRegion to use CXXMethodDecl::getThisType instead of calculating it by hand.<br></blockquote></div><div><br>Please don't do this for now. CXXMethodDecl::getThisType() takes qualifiers into account. But in the analyzer, we sometimes analyze methods in isolation. So we always use unqualified type. </div>
</div></blockquote><blockquote class="gmail_quote" style="margin:0pt 0pt 0pt 0.8ex;border-left:1px solid rgb(204, 204, 204);padding-left:1ex"><div class="gmail_quote"><div> </div></div></blockquote></div><div>What would this change impact? Maybe there should be a comment regarding this, because it's counter-intuitive.</div>
</div></blockquote></div><div><br>To be more precise, we cannot do this. We do not always have CXXMethodDecl. We sometimes only have CXXRecordDecl when visiting constructors.<br> </div></div></blockquote><div>But what did you meant by analyzing methods in isolation? What would be impacted by using type of 'this' with const <meta charset="utf-8">qualifier for methods that are const qualified?</div>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex;"><div class="gmail_quote"><div> </div></div></blockquote><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex;">
<div class="gmail_quote"><div class="im"><blockquote class="gmail_quote" style="margin:0pt 0pt 0pt 0.8ex;border-left:1px solid rgb(204, 204, 204);padding-left:1ex">
<div class="gmail_quote"><div>
<blockquote class="gmail_quote" style="margin:0pt 0pt 0pt 0.8ex;border-left:1px solid rgb(204, 204, 204);padding-left:1ex"><div class="gmail_quote"><div><blockquote class="gmail_quote" style="margin:0pt 0pt 0pt 0.8ex;border-left:1px solid rgb(204, 204, 204);padding-left:1ex">
<br>
Modified:<br>
cfe/trunk/lib/Checker/GRCXXExprEngine.cpp<br>
<br>
Modified: cfe/trunk/lib/Checker/GRCXXExprEngine.cpp<br>
URL: <a href="http://llvm.org/viewvc/llvm-project/cfe/trunk/lib/Checker/GRCXXExprEngine.cpp?rev=119341&r1=119340&r2=119341&view=diff" target="_blank">http://llvm.org/viewvc/llvm-project/cfe/trunk/lib/Checker/GRCXXExprEngine.cpp?rev=119341&r1=119340&r2=119341&view=diff</a><br>
==============================================================================<br>
--- cfe/trunk/lib/Checker/GRCXXExprEngine.cpp (original)<br>
+++ cfe/trunk/lib/Checker/GRCXXExprEngine.cpp Tue Nov 16 02:50:38 2010<br>
@@ -66,8 +66,7 @@<br>
<br>
const CXXThisRegion *GRExprEngine::getCXXThisRegion(const CXXRecordDecl *D,<br>
const StackFrameContext *SFC) {<br>
- Type *T = D->getTypeForDecl();<br>
- QualType PT = getContext().getPointerType(QualType(T, 0));<br>
+ QualType PT = D->getThisType(getContext());<br>
return ValMgr.getRegionManager().getCXXThisRegion(PT, SFC);<br>
}<br>
<br>
<br>
<br>
_______________________________________________<br>
cfe-commits mailing list<br>
<a href="mailto:cfe-commits@cs.uiuc.edu" target="_blank">cfe-commits@cs.uiuc.edu</a><br>
<a href="http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits" target="_blank">http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits</a><br>
</blockquote></div></div><br>
</blockquote></div></div><br>
</blockquote></div></div><br>
</blockquote></div><br>