<br><br><div class="gmail_quote">2010/9/20 Marcin Świderski <span dir="ltr"><<a href="mailto:marcin.sfider@gmail.com">marcin.sfider@gmail.com</a>></span><br><blockquote class="gmail_quote" style="margin: 0pt 0pt 0pt 0.8ex; border-left: 1px solid rgb(204, 204, 204); padding-left: 1ex;">
<div class="gmail_quote">W dniu 20 września 2010 03:25 użytkownik Zhongxing Xu <span dir="ltr"><<a href="mailto:xuzhongxing@gmail.com" target="_blank">xuzhongxing@gmail.com</a>></span> napisał:<div><div></div><div class="h5">
<br><blockquote class="gmail_quote" style="margin: 0pt 0pt 0pt 0.8ex; border-left: 1px solid rgb(204, 204, 204); padding-left: 1ex;">
Hi Marcin,<br><br>I'll stop working on this and wait for you. Please don't be mad at me. :)<br><br><div class="gmail_quote">2010/9/20 Zhongxing Xu <span dir="ltr"><<a href="mailto:xuzhongxing@gmail.com" target="_blank">xuzhongxing@gmail.com</a>></span><div>
<div></div><div><br>
<blockquote class="gmail_quote" style="margin: 0pt 0pt 0pt 0.8ex; border-left: 1px solid rgb(204, 204, 204); padding-left: 1ex;">Hi Marcin,<br><br>I'm sorry that I didn't talk with about this piece of work. I really should let you work on it. The main reason that I did this is because I have the impression that you might be busy and only have time to work on this at the week end. I just want to accelerate the progress in this area. No offense. <br>
<br>No handling of other language constructs is because we want to keep the patches small.<br><br><div class="gmail_quote">2010/9/20 Marcin Świderski <span dir="ltr"><<a href="mailto:marcin.sfider@gmail.com" target="_blank">marcin.sfider@gmail.com</a>></span><div>
<div></div><div><br>
<blockquote class="gmail_quote" style="margin: 0pt 0pt 0pt 0.8ex; border-left: 1px solid rgb(204, 204, 204); padding-left: 1ex;"><div class="gmail_quote">2010/9/18 Zhongxing Xu <span dir="ltr"><<a href="mailto:xuzhongxing@gmail.com" target="_blank">xuzhongxing@gmail.com</a>></span><div>
<div></div><div><br><blockquote class="gmail_quote" style="margin: 0pt 0pt 0pt 0.8ex; border-left: 1px solid rgb(204, 204, 204); padding-left: 1ex;">
This patch adds automatic variable's dtors to the CFG. It uses LocalScope to<br>record the automatic variables in each scope. When building the CFG,<br>CleanupPoints are inserted at ReturnStmt, CompoundStmt and GotoStmt. <br>
<br>After the building process, dtors are inserted into the cleanup points.<br><br>To hook up the LocalScope when entering a CompoundStmt, now autoCreate a block.<br>This may potentially create redundant blocks. But I think it's easy to remove<br>
them.<br><br>Some code is tricky. It is so to guarantee the correct order the dtors are <br>inserted. I'm not sure they are the best approach.<br><br>Later we would add an option to control the CFG build option. Currently <br>
adding implicit dtors are disabled. If it is enabled, some c++ test cases would <br>fail.<br><br>Some test cases that this patch can handle are attached. They can be tested by changing <br><br>if (BuildOpts.AddImplicitDtors) {<br>
<br>to <br><br>if (true) {<br><br></blockquote></div></div><div>I don't want to be rude, but I don't like that you've hijacked topic I was working on.</div><div>Is this normal practice on this project? If you (or somebody else) thinks that</div>
<div>I shouldn't work on this please contact me before doubling my work.</div><div><br></div><div>As for the patch I see no handling of:</div><div>- implicit scopes in if/else/for/while/do/switch,</div><div>- condition variables in if/while/for/switch,</div>
<div>- temporaries with lifetime extended by binding to const reference.</div><div><br></div><font color="#888888"><div>Marcin</div></font></div>
</blockquote></div></div></div><br>
</blockquote></div></div></div><br>
</blockquote></div></div></div>I work on this for my MSc. During last week I had to write some text for it to
<div>show progress. I will try to work more on coding. It would be really helpful</div><div>if you would not commit your patch as it differs greatly from what I have</div><div>prepared (as you saw in may, too big, patch).</div>
<div><br></div><font color="#888888"><div>Marcin</div>
</font></blockquote></div><br>Sure. I'll suspend it. Thank you for working on this!<br>