<html><head></head><body style="word-wrap: break-word; -webkit-nbsp-mode: space; -webkit-line-break: after-white-space; "><br><div><div>On Jul 5, 2010, at 11:55 PM, Nick Lewycky wrote:</div><br class="Apple-interchange-newline"><blockquote type="cite">This patch adds support for an attribute used to indicate that the function in question will not loop indefinitely. This is a counter-part to the LLVM patch <a href="http://lists.cs.uiuc.edu/pipermail/llvm-commits/Week-of-Mon-20100705/103672.html" target="_blank">http://lists.cs.uiuc.edu/pipermail/llvm-commits/Week-of-Mon-20100705/103672.html</a> which must be applied first.<br>
<br>The idea is that we can't currently delete the dead code:<br> void foo(set<int> *s) { s->find(10); }<br>because the compiler is afraid that set<>::find may have the side-effect of infinite looping. With a halting attribute manually applied in key places, such as the declaration of find(), we can unstick dead code elimination and ultimately reduce code size.<br>
<br>Please review!<br></blockquote></div><div><br></div><div>The patch looks good, although you're missing PCH (de-)serialization code for the new attribute.</div><br><div><span class="Apple-tab-span" style="white-space:pre"> </span>- Doug</div></body></html>