<div class="gmail_quote">On Sun, Mar 7, 2010 at 3:28 PM, Douglas Gregor <span dir="ltr"><<a href="mailto:dgregor@apple.com">dgregor@apple.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex;">
Author: dgregor<br>
Date: Sun Mar  7 17:28:27 2010<br>
New Revision: 97925<br>
<br>
URL: <a href="http://llvm.org/viewvc/llvm-project?rev=97925&view=rev" target="_blank">http://llvm.org/viewvc/llvm-project?rev=97925&view=rev</a><br>
Log:<br>
Downgrade errors when trying to catch a pointer or reference to<br>
incomplete type to warnings; GCC (and EDG in GCC compatibility mode)<br>
permit such handles. Fixes PR6527.<br>
<br>
Modified:<br>
    cfe/trunk/test/SemaCXX/exceptions.cpp<br>
    cfe/trunk/test/SemaTemplate/instantiate-function-1.cpp<br></blockquote><div><br></div><div>Looks like only the test updates and not the fix were submitted. ;] I reverted in r97926 to get the build green.</div><div> </div>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex;">
<br>
Modified: cfe/trunk/test/SemaCXX/exceptions.cpp<br>
URL: <a href="http://llvm.org/viewvc/llvm-project/cfe/trunk/test/SemaCXX/exceptions.cpp?rev=97925&r1=97924&r2=97925&view=diff" target="_blank">http://llvm.org/viewvc/llvm-project/cfe/trunk/test/SemaCXX/exceptions.cpp?rev=97925&r1=97924&r2=97925&view=diff</a><br>

==============================================================================<br>
--- cfe/trunk/test/SemaCXX/exceptions.cpp (original)<br>
+++ cfe/trunk/test/SemaCXX/exceptions.cpp Sun Mar  7 17:28:27 2010<br>
@@ -12,8 +12,8 @@<br>
   } catch(float i) {<br>
   } catch(void v) { // expected-error {{cannot catch incomplete type 'void'}}<br>
   } catch(A a) { // expected-error {{cannot catch incomplete type 'struct A'}}<br>
-  } catch(A *a) { // expected-error {{cannot catch pointer to incomplete type 'struct A'}}<br>
-  } catch(A &a) { // expected-error {{cannot catch reference to incomplete type 'struct A'}}<br>
+  } catch(A *a) { // expected-warning {{pointer to incomplete type 'struct A'}}<br>
+  } catch(A &a) { // expected-warning {{reference to incomplete type 'struct A'}}<br>
   } catch(Abstract) { // expected-error {{variable type 'Abstract' is an abstract class}}<br>
   } catch(...) {<br>
     int j = i; // expected-error {{use of undeclared identifier 'i'}}<br>
<br>
Modified: cfe/trunk/test/SemaTemplate/instantiate-function-1.cpp<br>
URL: <a href="http://llvm.org/viewvc/llvm-project/cfe/trunk/test/SemaTemplate/instantiate-function-1.cpp?rev=97925&r1=97924&r2=97925&view=diff" target="_blank">http://llvm.org/viewvc/llvm-project/cfe/trunk/test/SemaTemplate/instantiate-function-1.cpp?rev=97925&r1=97924&r2=97925&view=diff</a><br>

==============================================================================<br>
--- cfe/trunk/test/SemaTemplate/instantiate-function-1.cpp (original)<br>
+++ cfe/trunk/test/SemaTemplate/instantiate-function-1.cpp Sun Mar  7 17:28:27 2010<br>
@@ -194,7 +194,7 @@<br>
 template<typename T> struct TryCatch0 {<br>
   void f() {<br>
     try {<br>
-    } catch (T t) { // expected-error{{incomplete type}} \<br>
+    } catch (T t) { // expected-warning{{incomplete type}} \<br>
                     // expected-error{{abstract class}}<br>
     } catch (...) {<br>
     }<br>
<br>
<br>
_______________________________________________<br>
cfe-commits mailing list<br>
<a href="mailto:cfe-commits@cs.uiuc.edu">cfe-commits@cs.uiuc.edu</a><br>
<a href="http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits" target="_blank">http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits</a><br>
</blockquote></div><br>