<html><head></head><body style="word-wrap: break-word; -webkit-nbsp-mode: space; -webkit-line-break: after-white-space; "><div><div>20 jan 2010 kl. 19.33 skrev Sean Hunt:</div><br class="Apple-interchange-newline"><blockquote type="cite"><div>On 01/10/2010 10:20 AM, Anders Carlsson wrote:<br><blockquote type="cite">Sure! (I'm on vacation this week but I'll try to find some time :)<br></blockquote><blockquote type="cite"><br></blockquote><blockquote type="cite">Anders<br></blockquote><blockquote type="cite"><br></blockquote><blockquote type="cite">8 jan 2010 kl. 10.45 skrev Chris Lattner:<br></blockquote><blockquote type="cite"><br></blockquote><blockquote type="cite"><blockquote type="cite">On Jan 7, 2010, at 12:52 AM, Sean Hunt wrote:<br></blockquote></blockquote><blockquote type="cite"><blockquote type="cite"><blockquote type="cite">This patch fixes <a href="http://llvm.org/bugs/show_bug.cgi?id=5966">http://llvm.org/bugs/show_bug.cgi?id=5966</a> by making the same changes to clang made to fix <a href="http://gcc.gnu.org/bugzilla/show_bug.cgi?id=31775">http://gcc.gnu.org/bugzilla/show_bug.cgi?id=31775</a><br></blockquote></blockquote></blockquote><blockquote type="cite"><blockquote type="cite"><br></blockquote></blockquote><blockquote type="cite"><blockquote type="cite">Anders, can you review this mangling patch when you get a chance?<br></blockquote></blockquote><blockquote type="cite"><blockquote type="cite"><br></blockquote></blockquote><blockquote type="cite"><blockquote type="cite">-Chris<br></blockquote></blockquote><blockquote type="cite"><br></blockquote><br>Ping?<br><br></div></blockquote><div><br></div>Patch looks good! Two minor comments:</div><div><br></div><div>I think you can put the test case in mangle.cpp, just put it inside its own namespace:</div><div><br></div><div>// PR5966 </div><div>namespace PR5966 {</div><div>}</div><div><br></div><div><blockquote type="cite"><div><font class="Apple-style-span" color="#000000">+ ND->getDeclContext()->isFileContext())</font></div><div><font class="Apple-style-span" color="#000000">+ Out << "L";</font></div></blockquote><div><br></div><div>Can just use 'L' here instead.</div><div><br></div><div>Thanks for fixing this!</div><div><br></div><div>Anders</div></div></body></html>