<html><head></head><body style="word-wrap: break-word; -webkit-nbsp-mode: space; -webkit-line-break: after-white-space; "><br><div><div>On Nov 4, 2009, at 1:53 PM, John Thompson wrote:</div><br class="Apple-interchange-newline"><blockquote type="cite"><div>Here's another go at it, adding stuff for PCH and the driver. I put in a partial test of the driver change in test/Driver/clang_f_opts.c, which I hope is an appropriate place.</div></blockquote><div><br></div>Looks good, but could you address this comment</div><div><br><blockquote type="cite"><div class="gmail_quote"><blockquote style="BORDER-LEFT: #ccc 1px solid; MARGIN: 0px 0px 0px 0.8ex; PADDING-LEFT: 1ex" class="gmail_quote"><blockquote style="border-left-color: rgb(204, 204, 204); border-left-width: 1px; border-left-style: solid; margin-top: 0px; margin-right: 0px; margin-bottom: 0px; margin-left: 0.8ex; padding-left: 1ex; position: static; z-index: auto; " class="gmail_quote"><br><br>
<div class="im">The change to the wchar.c test allows it to pass on Windows (and still pass on Linux, which defaults to int for wchar_t).<br></div></blockquote><br>
<div>
<div></div>
<div class="h5">I'd like to retain the test that we use "int" for the other targets. Could you do something like<br><br> RUN: clang-cc %s -fsyntax-only -triple i686-pc-linux-gnu -verify -DWCHAR_T_TYPE="int" &&<br>
RUN: clang-cc %s -fsyntax-only -fshort-wchar -verify -DWCHAR_T_TYPE="unsigned short"<br><br>then use WCHAR_T_TYPE as the element type of the t1 and t2 arrays?<br><br> - Doug<br></div></div></blockquote></div>
</blockquote></div><br><div>before committing?</div><div><br></div><div><span class="Apple-tab-span" style="white-space:pre"> </span>- Doug</div></body></html>