<html><head></head><body style="word-wrap: break-word; -webkit-nbsp-mode: space; -webkit-line-break: after-white-space; "><br><div><div>On Oct 22, 2009, at 6:54 PM, John Thompson wrote:</div><br class="Apple-interchange-newline"><blockquote type="cite">On Windows there was an ordering problem in the push_back if the internal array needed growing, copying an element already deleted in the grow (I think). With your approval, I'll check it in. This will fix an assert in running the Preprocessor/pushable-diagnostics.c test on Windows.<br clear="all"></blockquote><div><br></div>Looks great to me. The problem is not <span class="Apple-style-span" style="font-family: Menlo; font-size: 10px; ">MSVC</span> specific, please change the comment to say it "avoids undefined behavior when the stack has to resize" or something like that.</div><div><br></div><div>-Chris</div><div><br><blockquote type="cite">
<div></div>
<div> </div>
<div>-John</div>
<div><br>-- <br>John Thompson<br><a href="mailto:John.Thompson.JTSoftware@gmail.com">John.Thompson.JTSoftware@gmail.com</a><br><br></div>
<span><diagnosticfix.patch></span>_______________________________________________<br>cfe-commits mailing list<br><a href="mailto:cfe-commits@cs.uiuc.edu">cfe-commits@cs.uiuc.edu</a><br>http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits<br></blockquote></div><br></body></html>