<html><head></head><body style="word-wrap: break-word; -webkit-nbsp-mode: space; -webkit-line-break: after-white-space; "><br><div><div>On Sep 20, 2009, at 12:13 AM, Daniel Dunbar wrote:</div><br class="Apple-interchange-newline"><blockquote type="cite"><span class="Apple-style-span" style="border-collapse: separate; font-family: Helvetica; font-size: medium; font-style: normal; font-variant: normal; font-weight: normal; letter-spacing: normal; line-height: normal; orphans: 2; text-indent: 0px; text-transform: none; white-space: normal; widows: 2; word-spacing: 0px; -webkit-border-horizontal-spacing: 0px; -webkit-border-vertical-spacing: 0px; -webkit-text-decorations-in-effect: none; -webkit-text-size-adjust: auto; -webkit-text-stroke-width: 0px; ">Hi Ted,<br><br>On Tue, Sep 1, 2009 at 11:33 AM, Ted Kremenek <<a href="mailto:kremenek@apple.com">kremenek@apple.com</a>> wrote:<br><blockquote type="cite">Author: kremenek<br></blockquote><blockquote type="cite">Date: Tue Sep 1 13:33:16 2009<br></blockquote><blockquote type="cite">New Revision: 80700<br></blockquote><blockquote type="cite"><br></blockquote><blockquote type="cite">URL:<span class="Apple-converted-space"> </span><a href="http://llvm.org/viewvc/llvm-project?rev=80700&view=rev">http://llvm.org/viewvc/llvm-project?rev=80700&view=rev</a><br></blockquote><blockquote type="cite">Log:<br></blockquote><blockquote type="cite">Add test case from <<a href="rdar://problem/7184450">rdar://problem/7184450</a>>.<br></blockquote><br>This is a super nit-pick, but could these tests be more reduced?<br><br>The problem with auto reduced test cases which aren't reduced to the<br>real bug is that they are hard to read, but the real issue is that<br>because the test case doesn't *really* show the problem, when things<br>change in the future and a test needs updating, it can be impossible<br>to tell whether it is testing what it is supposed to anymore.<br></span></blockquote></div><br><div>Hi Daniel,</div><div><br></div><div>The only thing that is autoreduced are the forward declarations (at the top of the patch). The actual test case was hand reduced (at the bottom).</div><div><br></div><div>Ted</div></body></html>