<html><head></head><body style="word-wrap: break-word; -webkit-nbsp-mode: space; -webkit-line-break: after-white-space; "><br><div><div>On Aug 14, 2009, at 2:48 PM, Eli Friedman wrote:</div><br class="Apple-interchange-newline"><blockquote type="cite"><span class="Apple-style-span" style="border-collapse: separate; font-family: Helvetica; font-size: medium; font-style: normal; font-variant: normal; font-weight: normal; letter-spacing: normal; line-height: normal; orphans: 2; text-indent: 0px; text-transform: none; white-space: normal; widows: 2; word-spacing: 0px; -webkit-border-horizontal-spacing: 0px; -webkit-border-vertical-spacing: 0px; -webkit-text-decorations-in-effect: none; -webkit-text-size-adjust: auto; -webkit-text-stroke-width: 0px; ">On Fri, Aug 14, 2009 at 1:49 PM, Ted Kremenek<<a href="mailto:kremenek@apple.com">kremenek@apple.com</a>> wrote:<br><blockquote type="cite">@@ -431,17 +438,18 @@<br></blockquote><blockquote type="cite"> return;<br></blockquote><blockquote type="cite"> }<br></blockquote><blockquote type="cite"><br></blockquote><blockquote type="cite">- if (!isFunctionOrMethod(d)) {<br></blockquote><blockquote type="cite">+ if (!isFunction(d)) {<br></blockquote><blockquote type="cite"> S.Diag(Attr.getLoc(), diag::warn_attribute_wrong_decl_type)<br></blockquote><blockquote type="cite"> << Attr.getName() << 0 /*function*/;<br></blockquote><blockquote type="cite"> return;<br></blockquote><blockquote type="cite"> }<br></blockquote><blockquote type="cite"><br></blockquote><blockquote type="cite">- if (FunctionDecl *FD = dyn_cast<FunctionDecl>(d)) {<br></blockquote><blockquote type="cite">- if (!FD->getResultType()->isPointerType()) {<br></blockquote><blockquote type="cite">- S.Diag(Attr.getLoc(), diag::warn_attribute_malloc_pointer_only);<br></blockquote><blockquote type="cite">- return;<br></blockquote><blockquote type="cite">- }<br></blockquote><blockquote type="cite">+ const FunctionDecl *FD = cast<FunctionDecl>(d);<br></blockquote><blockquote type="cite">+ QualType RetTy = FD->getResultType();<br></blockquote><blockquote type="cite">+<br></blockquote><blockquote type="cite">+ if (!(RetTy->isAnyPointerType() || RetTy->isBlockPointerType())) {<br></blockquote><blockquote type="cite">+ S.Diag(Attr.getLoc(), diag::warn_attribute_malloc_pointer_only);<br></blockquote><blockquote type="cite">+ return;<br></blockquote><blockquote type="cite"> }<br></blockquote><br>I believe we went through this before... isFunction doesn't guarantee<br>that d is a FunctionDecl.<br></span></blockquote></div><br><div>In the previous discussion, the code involved 'isFunctionOrMethod', which would return true for an ObjCMethodDecl. I just added 'isFunction'. When I read the previous objections to cast<FunctionDecl>, I thought it was mainly because the Decl could be an ObjCMethodDecl, but as you pointed out in your other email they are certainly other cases.</div></body></html>