<html><body style="word-wrap: break-word; -webkit-nbsp-mode: space; -webkit-line-break: after-white-space; "><br><div><div>On Jun 12, 2009, at 10:09 AM, David Majnemer wrote:</div><br class="Apple-interchange-newline"><blockquote type="cite">Please understand that this is my first attempt at trying to submit something, I apologize if I have done anything wrong.<div><br></div><div>Anyway, this patch has some changes to the warnings that we could emit. I personally felt that alternatives would be harder to read.</div> <div>If the patch is not up to snuff, I would be more than happy to try to fix it.</div> </blockquote><br></div><div>Hi David,</div><div><br></div><div>This looks nice to me, but it looks like you have some 4-space indentation in the patch:</div><div><br></div><div><div style="margin-top: 0px; margin-right: 0px; margin-bottom: 0px; margin-left: 0px; font: normal normal normal 10px/normal Menlo; ">+ if (rType->isFunctionPointerType() || lType->isFunctionPointerType()) {</div><div style="margin-top: 0px; margin-right: 0px; margin-bottom: 0px; margin-left: 0px; font: normal normal normal 10px/normal Menlo; ">+ if (isRelational) {</div><div style="margin-top: 0px; margin-right: 0px; margin-bottom: 0px; margin-left: 0px; font: normal normal normal 10px/normal Menlo; ">+ Diag(Loc, diag::ext_typecheck_ordered_comparison_of_function_pointers)</div><div style="margin-top: 0px; margin-right: 0px; margin-bottom: 0px; margin-left: 0px; font: normal normal normal 10px/normal Menlo; ">+ << lType << rType << lex->getSourceRange() << rex->getSourceRange();</div><div style="margin-top: 0px; margin-right: 0px; margin-bottom: 0px; margin-left: 0px; font: normal normal normal 10px/normal Menlo; ">+ }</div><div style="margin-top: 0px; margin-right: 0px; margin-bottom: 0px; margin-left: 0px; font: normal normal normal 10px/normal Menlo; ">+ }</div><div style="margin-top: 0px; margin-right: 0px; margin-bottom: 0px; margin-left: 0px; font: normal normal normal 10px/normal Menlo; ">+ if (((!LHSIsNull || isRelational) && LCanPointeeTy->isVoidType()) !=</div><div style="margin-top: 0px; margin-right: 0px; margin-bottom: 0px; margin-left: 0px; font: normal normal normal 10px/normal Menlo; ">+ ((!RHSIsNull || isRelational) && RCanPointeeTy->isVoidType())) {</div><div style="margin-top: 0px; margin-right: 0px; margin-bottom: 0px; margin-left: 0px; font: normal normal normal 10px/normal Menlo; ">+ Diag(Loc, diag::ext_typecheck_comparison_of_distinct_pointers)</div><div style="margin-top: 0px; margin-right: 0px; margin-bottom: 0px; margin-left: 0px; font: normal normal normal 10px/normal Menlo; ">+ << lType << rType << lex->getSourceRange() << rex->getSourceRange();</div><div style="margin-top: 0px; margin-right: 0px; margin-bottom: 0px; margin-left: 0px; font: normal normal normal 10px/normal Menlo; ">+ }</div><div style="margin-top: 0px; margin-right: 0px; margin-bottom: 0px; margin-left: 0px; font: normal normal normal 10px/normal Menlo; "> // Simple check: if the pointee types are identical, we're done.</div><div><font class="Apple-style-span" face="Menlo" size="2"><span class="Apple-style-span" style="font-size: 10px;"><br></span></font></div><div><font class="Apple-style-span" face="Menlo" size="2"><span class="Apple-style-span" style="font-size: 10px;">Please change this to indent by 2, include a testcase and I'll apply it for you. </span></font></div></div><br><div>Thanks!</div><div><br></div><div>-Chris</div></body></html>