<html><body style="word-wrap: break-word; -webkit-nbsp-mode: space; -webkit-line-break: after-white-space; "><br><div><div>On May 12, 2009, at 11:44 PM, Chris Lattner wrote:</div><br class="Apple-interchange-newline"><blockquote type="cite">On May 12, 2009, at 1:06 PM, Fariborz Jahanian wrote:<br><blockquote type="cite">URL: <a href="http://llvm.org/viewvc/llvm-project?rev=71578&view=rev">http://llvm.org/viewvc/llvm-project?rev=71578&view=rev</a><br></blockquote><blockquote type="cite">Log:<br></blockquote><blockquote type="cite">Fixed typos, used DenseSet for keeping track of<br></blockquote><blockquote type="cite">selectors which need use Nonfrgile API for<br></blockquote><blockquote type="cite">message dispatch.<br></blockquote><br>Thanks Fariborz, one more minor thing:<br><br><blockquote type="cite">+ NonLegacyDispatchMethods.insert(GetUnarySelector("isEqual"));<br></blockquote><blockquote type="cite">+ NonLegacyDispatchMethods.insert(GetUnarySelector("addObject"));<br></blockquote><blockquote type="cite">+ // "countByEnumeratingWithState:objects:count" auch!<br></blockquote><br>auch?<br><br><blockquote type="cite"><br></blockquote><blockquote type="cite">+ llvm::SmallVector<IdentifierInfo *, 4> KeyIdents;<br></blockquote><blockquote type="cite">+ KeyIdents.push_back(<br></blockquote><blockquote type="cite">+ &CGM.getContext().Idents.get("countByEnumeratingWithState"));<br></blockquote><blockquote type="cite">+ KeyIdents.push_back(&CGM.getContext().Idents.get("objects"));<br></blockquote><blockquote type="cite">+ KeyIdents.push_back(&CGM.getContext().Idents.get("count"));<br></blockquote><blockquote type="cite">+ NonLegacyDispatchMethods.insert(CGM.getContext().Selectors.getSelector(<br></blockquote><blockquote type="cite">+ 3, &KeyIdents[0]));<br></blockquote><br><br>This can use a simple C array like this:<br><br>IdentifierInfo *KeyIdents[] = {<br> &CGM.getContext().Idents.get("countByEnumeratingWithState"),<br> &CGM.getContext().Idents.get("objects"),<br> &CGM.getContext().Idents.get("count")<br>};<br><br>.. getSelector(3, KeyIdents);</blockquote><div><br class="webkit-block-placeholder"></div>Thanks for the review. Done in: <a href="http://llvm.org/viewvc/llvm-project?rev=71674&view=rev">http://llvm.org/viewvc/llvm-project?rev=71674&view=rev</a></div><div><br class="webkit-block-placeholder"></div><div>- Fariborz</div><div><br><blockquote type="cite"><br><br>-Chris<br><br><br><blockquote type="cite"><br></blockquote><blockquote type="cite">+ }<br></blockquote><blockquote type="cite">+ return (NonLegacyDispatchMethods.count(Sel) == 0);<br></blockquote><blockquote type="cite">}<br></blockquote><blockquote type="cite"><br></blockquote><blockquote type="cite">// Metadata flags<br></blockquote><blockquote type="cite"><br></blockquote><blockquote type="cite"><br></blockquote><blockquote type="cite">_______________________________________________<br></blockquote><blockquote type="cite">cfe-commits mailing list<br></blockquote><blockquote type="cite"><a href="mailto:cfe-commits@cs.uiuc.edu">cfe-commits@cs.uiuc.edu</a><br></blockquote><blockquote type="cite"><a href="http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits">http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits</a><br></blockquote><br></blockquote></div><br></body></html>